Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1354969imm; Wed, 8 Aug 2018 15:42:29 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx7ygjNintfNcKRS3qmW6yTIRKTjKgtcPmvbs7xp2D+Vwt4IeWAZPm/eVJODqQ9H+Fvbuhd X-Received: by 2002:a63:121a:: with SMTP id h26-v6mr4295982pgl.316.1533768149922; Wed, 08 Aug 2018 15:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533768149; cv=none; d=google.com; s=arc-20160816; b=JO4MIayy3x8dQUDRFVOFJqYE4m0NgnJOqnb7G0wKNhZEalVyvlPxOY6lLgU71wIttg DpSDXqh3tSf/b/om3ZjibemGxrQ6uLsq/vdl5Wg/tC6Lo3lvp6QJIJykEZPF8p6VPx8O CVYbjuh/Ap9yg84Ms5NxNNDBNLU9XYfKtvPH2sL7M5vTVGernoEAfUu++BRZcIJ3mRa+ t7VfapMNc7iGyK0VARmZ6TYeko9hMTkUWen7idJ4L4GpPvNTYHDPQrD76Gss52yW8rrV M34TBPVm8k8cQ/eIY9+DsijiUr+7EyvejowodDJ6kBsYgZfBeL5y/fJBlGJKCR4JDo70 7CSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=dDuXkhUBYdFTrcvkeDG7iU13R+74x+AncC7r16EKwVQ=; b=nUBuWlVGDxbUwf/2a1TnnhjgBR/tSYGDBKWMWat9FeAvAN28JTwGUdPDZcRcZTz6Qj PDslUomdILtk5TcAyWUvekJqV2tDDnhfZSMYyZtmTxxb845J1BWPxkmnnewFTo0JDsc9 PUsQlQqSoGLf1E3e+WmkGIOjaJNrP1uhaXl6tljNa5tTXWclRtYw21iZi0GYx/VdMBR6 XGPSQLo50goXDHpxFVf6GJZ7mahXogHN6HlHKdYfnenBZuClNYJJa8QeTPQByGi4k/FM 1FEMPcVvk70sO5A50qJuybJAE4a/4BoUeXWUF8Ny0w3i1+TicHJIaNJOoDfMBJAy7bGt u6zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 72-v6si5532964pfq.6.2018.08.08.15.42.15; Wed, 08 Aug 2018 15:42:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731696AbeHIBDN (ORCPT + 99 others); Wed, 8 Aug 2018 21:03:13 -0400 Received: from nautica.notk.org ([91.121.71.147]:47021 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729729AbeHIBDN (ORCPT ); Wed, 8 Aug 2018 21:03:13 -0400 Received: by nautica.notk.org (Postfix, from userid 1001) id 716D7C009; Thu, 9 Aug 2018 00:41:26 +0200 (CEST) Date: Thu, 9 Aug 2018 00:41:11 +0200 From: Dominique Martinet To: Dmitry Vyukov Cc: Tomas Bortoli , David Miller , v9fs-developer@lists.sourceforge.net, netdev , LKML , syzkaller Subject: Re: [PATCH] 9p: fix NULL pointer dereferences Message-ID: <20180808224111.GB12890@nautica> References: <20180726081049.10527-1-tomasbortoli@gmail.com> <20180726081727.GA6699@nautica> <20180726094849.GA18334@nautica> <20180726142109.GA4235@nautica> <20180726221527.GA9426@nautica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry Vyukov wrote on Wed, Aug 08, 2018: > > If you want to factor it in, v9fs_mount does not know which transport is > > used, but p9_client_create does know - although the functions/structs > > are all static so you need to check clnt->trans_mod->name with strcmp > > and I'm honestly not sure that's better than checking in each function.. > > > > But, as usual I'm happy as long as it works, so pick your poison :) > > So let's proceed with checking in each transport function? Yes, he's done it a while ago, just didn't se the in-reply-to field to keep part of the thread but the Reported-by was here: http://lkml.kernel.org/r/20180727110558.5479-1-tomasbortoli@gmail.com This is in linux-next right now as 631263a1b23c71 -- Dominique