Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   TongZhang <ztong@vt.edu>
Content-Type: text/plain;
        charset=us-ascii
Content-Transfer-Encoding: 8BIT
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Question about inode_permission() check in unix_find_other()
Message-Id: <91367B74-6AC5-4E14-AE13-30FF6A7A6592@vt.edu>
Date:   Wed, 8 Aug 2018 18:09:57 -0700
Cc:     wenbo.s@samsung.com, ahmedmoneeb@gmail.com
To:     davem@davemloft.net, garsilva@embeddedor.com,
        matthew@mjdsystems.ca, willemb@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Networking Subsystem Maintainers,

I have a quick question about inode_permission() check in unix_find_other(),

I was doing a code review on net/unix/af_unix.c and found out that the inode_permission() check is confusing here.

Since the unix socket is presented as a file, and will be permission checked by VFS when user open it,
why do we still need the inode_permission() check in unix_find_other() anyway?

Thank you,
- Tong