Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] blk-mq: count the hctx as active before allocate tag
To:     Jens Axboe <axboe@kernel.dk>
Cc:     tom.leiming@gmail.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1533722212-20327-1-git-send-email-jianchao.w.wang@oracle.com>
 <faf3e267-b6e6-7a44-2c14-91fd9bf63371@kernel.dk>
From:   "jianchao.wang" <jianchao.w.wang@oracle.com>
Message-ID: <b0da11e4-d542-a4d0-545b-177ffedaabaa@oracle.com>
Date:   Thu, 9 Aug 2018 09:24:30 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <faf3e267-b6e6-7a44-2c14-91fd9bf63371@kernel.dk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jens

On 08/08/2018 10:40 PM, Jens Axboe wrote:
> On 8/8/18 3:56 AM, Jianchao Wang wrote:
>> Currently, we count the hctx as active after allocate driver tag
>> successfully. The other shared-tags users could exhaust the driver
>> tags and starve a non-active and waiting-tag hctx. Count the hctx as
>> active before try to allocate driver tag to fix this.
> 
> Patch looks good, but please add some comments along the way.
> 

Yes, I will do that and post the V3.

Thanks
Jianchao