Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1507036imm; Wed, 8 Aug 2018 19:19:36 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyHvoNv04jtcbRmgq+PioFux6b/fyqQLB6WBOrfQFExa3mauD10whiQ3CWIlbnq823TcQe4 X-Received: by 2002:a17:902:c6b:: with SMTP id 98-v6mr197148pls.233.1533781176044; Wed, 08 Aug 2018 19:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533781176; cv=none; d=google.com; s=arc-20160816; b=CTDbZlUCe9hKBf4PE6EgQMaLQNux76mTYYRKpi78/zcHEdXcyZ5fqlrUvByM4Irk3d 29oyzf53Ifpeby5WJnA3WdDjTQYhpvsb9iBk84xQAuuCSEZFlJabux1hnsVTcKOV1+Bx Fis5ZZD0/0CSerokMXmBtbg7Hz0Md7Mu9cEGSP/Sj2EUE0cWyQxvkqknpigh87f4yl/A +vUt8mJZjhgipjOeC4UIG8bCLRUb20QkQAZb4QA+nAaoC6DB9LQ/twvKwLLf/RaTgb3C dMf82wLE/2906OHJhPlF3sk37T553kEY/QXcpkkvq+Xtu75BI7Bj3yvxmjX3/ROM4xe3 tlqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=Dq9bGOpeR6OCf6JFeh0LpDBhBPMr9Uf00zzXISs1awQ=; b=Qs43llrWyOsimw7Wc9FWNy3skrv1DQB4ePr0QLIfK8EPzlyF35FFhnzpuv9z/IFlSi 4fv8wdQZOUSACpQ+VLYt3qspdwKnFuEJOCetAOnLVqeNJda4k5PsqidrJN9F3S9i1nWL Oeaf6KPIjwmshZIpqLf2xtwK2iaFPD8EOWERGKqM7xKwGVIpWCJ4YXWxViXxZ8oH2mg2 qxdNE8TUPAL25sn7y98ABbTJkak+wtAQOPGTlWD1uO/GQf6uUn2t+LIwJ9X1FnbOB5+8 JkUr1NJ/ycJ0wzG+asn4/Ko6CHcOCQDmrgWw5122yMYSgOIquLdYO3RyCngoKxqgSstP uJSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=bMjaO2uC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9-v6si6305407pfh.240.2018.08.08.19.19.21; Wed, 08 Aug 2018 19:19:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=bMjaO2uC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727676AbeHIEk2 (ORCPT + 99 others); Thu, 9 Aug 2018 00:40:28 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42690 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725757AbeHIEk2 (ORCPT ); Thu, 9 Aug 2018 00:40:28 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w792DPkY037980; Thu, 9 Aug 2018 02:17:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=Dq9bGOpeR6OCf6JFeh0LpDBhBPMr9Uf00zzXISs1awQ=; b=bMjaO2uCIm7iIMRhc4+ryAytq6A6KHjjCk6TPiiyOXT/IFlWwGWsD0vbA5zZtam6Zrpm A1STdfv1yaU0UXSWccG+2ai7NO2wk2WU44+cQugMTDXVZZvgzKuX+rebjv2nW1lCozDc 3DbIupeF4GBP+uqXICOejmwjGWsr1rGqn6EKjMhrds/3nzsU4U3jETsOnwV+6lIrRN9A nr3r9bv5PTxb5iB2HKVIn+qLW8MzWSmPf04APU/GxXG2L7RVRK6/efuanyoppLIbUUWi 2JBzysL0RLPNqoqqgbJyfkDZeCuJbfxGJXCGUdV/g6hCU/Y/Yk43ssnjhBcNbbAdg3uE wA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2kn4sq038v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Aug 2018 02:17:49 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w792Hn3G029250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Aug 2018 02:17:49 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w792HlCo007821; Thu, 9 Aug 2018 02:17:47 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 08 Aug 2018 18:16:44 -0700 To: Colin King Cc: Kai =?utf-8?Q?M=C3=A4kisara?= , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] st: remove redundant pointer STbuffer From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180803104752.17081-1-colin.king@canonical.com> Date: Wed, 08 Aug 2018 21:16:42 -0400 In-Reply-To: <20180803104752.17081-1-colin.king@canonical.com> (Colin King's message of "Fri, 3 Aug 2018 11:47:52 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8979 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=497 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808090023 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Pointer STbuffer is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'STbuffer' set but not used [-Wunused-but-set-variable] Applied to 4.19/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering