Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.60.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;
Subject: Re: [PATCH 1/3] microblaze: Replace NR_syscalls macro from
 asm/unistd.h
To:     Firoz Khan <firoz.khan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kate Stewart <kstewart@linuxfoundation.org>
CC:     <y2038@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
        <linux-arch@vger.kernel.org>, <arnd@arndb.de>,
        <deepa.kernel@gmail.com>, <marcin.juszkiewicz@linaro.org>
References: <1533792466-4227-1-git-send-email-firoz.khan@linaro.org>
 <1533792466-4227-2-git-send-email-firoz.khan@linaro.org>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <f1e95c4d-4f02-263d-7f35-cc87bc657fbb@xilinx.com>
Date:   Thu, 9 Aug 2018 08:48:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1533792466-4227-2-git-send-email-firoz.khan@linaro.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2018 06:48:41.1790
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d4993fe0-c5e8-4c4d-27dc-08d5fdc42703
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0201MB3516
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9.8.2018 07:27, Firoz Khan wrote:
> __NR_syscalls macro holds the number of system call exist in this
> architecture. This macro is currently the part of asm/unistd.h file.
> We have change the value of __NR_syscalls, if we add or delete a
> system call.
> 
> One of the patch in this patch series has a script which will
> generate a uapi header based on syscall.tbl file. The syscall.tbl
> file contains the number of system call information. So we have
> two option to update __NR_syscalls value.
> 
> 1. Update __NR_syscalls in asm/unistd.h manually by counting the
>    no.of system calls. No need to update __NR_syscalls untill
>    we either add a new system call or delete an existing system
>    call.
> 
> 2. We can keep this feature it above mentioned script, that'll
>    count the number of syscalls and keep it in a generated file.
>    In this case we don't need to explicitly update __NR_syscalls
>    in asm/unistd.h file.
> 
> The 2nd option will be the recommended one. For that, I moved the
> NR_syscalls macro from asm/unistd.h to uapi/asm/unistd.h. The macro
> name also changed form NR_syscalls to __NR_syscalls for making the
> name convention same across all architecture. While __NR_syscalls
> isn't strictly part of the uapi, having it as part of the generated
> header to simplifies the implementation.

This macro was in unistd.h in past but it was moved out because it was
causing problem with strace.

commit 40c2702a02b755e0183b702778331b351f3be20c
Author:     Michal Simek <michal.simek@xilinx.com>
AuthorDate: Mon Jul 8 09:50:24 2013 +0200
Commit:     Michal Simek <michal.simek@xilinx.com>
CommitDate: Wed Jul 10 07:32:09 2013 +0200

    microblaze: Move __NR_syscalls from uapi


That's why I don't think this is the right thing to do.
I have grepped strace and glibc and none is using this macro that's why
I think it shouldn't be exported via uapi.

Thanks,
Michal