Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1698045imm; Thu, 9 Aug 2018 00:00:16 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxSfsaYRzvFOGHcvZtLSYHOYpxyzyzRUYVJ5BD5WfUY3B7blRv83M8YHrpXRWwG6UobKo9t X-Received: by 2002:a63:f111:: with SMTP id f17-v6mr892574pgi.87.1533798016292; Thu, 09 Aug 2018 00:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533798016; cv=none; d=google.com; s=arc-20160816; b=iYRsjGFqcPyyCVchXqpArWMfwMg96bgCCSY3V3FoJKNZoV9ly1UcdJNlyuscW4QQkE dLtNIhLh37bxlQ5Cs+0HQAUTjQs7Twg3XfCUCwjk9OqVu5UAxrKsBQZFcdy34y62Peh/ h+HVBovV+8BRKidO+0uYvR4SXrP3MleOzuorzCBP4gkBuZY7vFY+vZRV+Ux4O2l0TGsP tHwb4T13sYW9Ngsu3Gf6UcdEPLyT7CJI0cA74hrBzz5eAkP4wif4GjX3GXI05fg8vSwn ypnR8tMdQUbQUnuOtTl2tm3hJyVRjHjDlS5ZCuOGiEtRb4f7wRCc3hmsSej/ZQicE/NW dCQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=ep/dwVFIl3zjdV3rMjrJtRdFURZzMvc4fCiySf+nKs4=; b=yqzCCy29zjEHkGorWMoI41VyQsWtp0dfwPWbCnDFVdvWEOQ5GGHjX0VNLRZB768ph1 IsVFq+2wX6CXqlmrGUeKl1zT+9/j2nkcgmfxiWaVEcya2xRpp+mliPjZ0zDyq29rTlWB NRTxznejIrKpXC6SpNk/Tz1KOyhwSTWZpkDAEJ9RYYz8JCciSDmEMHGNNP5uw6yDSgrf BbT+arW3x9LwZ+Hmuv+kLfOKxLXge9M8nVdRrQWWepBsBYsHI2K8m+KOHapDLXJ3fPdu dXV9i5ht4OzkBlr9Zqj14pOAjCI+c6FQrHV7hSG2EddZcqubdicnPCNR4EdXw8Jr/vzs q51w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n64-v6si6778705pgn.247.2018.08.09.00.00.01; Thu, 09 Aug 2018 00:00:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbeHIJU7 (ORCPT + 99 others); Thu, 9 Aug 2018 05:20:59 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:43867 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbeHIJU5 (ORCPT ); Thu, 9 Aug 2018 05:20:57 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fnet2-0008JP-ME; Thu, 09 Aug 2018 00:57:32 -0600 Received: from [97.119.167.31] (helo=x220.int.ebiederm.org) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.87) (envelope-from ) id 1fnet2-00054s-6l; Thu, 09 Aug 2018 00:57:32 -0600 From: "Eric W. Biederman" To: Oleg Nesterov Cc: Andrew Morton , linux-kernel@vger.kernel.org, Wen Yang , majiang , Linus Torvalds , "Eric W. Biederman" Date: Thu, 9 Aug 2018 01:56:03 -0500 Message-Id: <20180809065605.32345-4-ebiederm@xmission.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <87wot0yqsx.fsf_-_@xmission.com> References: <87wot0yqsx.fsf_-_@xmission.com> X-XM-SPF: eid=1fnet2-00054s-6l;;;mid=<20180809065605.32345-4-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.167.31;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18P5HIB1jMRJ5LmCsIvjXhjXBbMBC9PmmE= X-SA-Exim-Connect-IP: 97.119.167.31 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa06.xmission.com X-Spam-Level: X-Spam-Status: No, score=0.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TooManySym_01,XMSubLong autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Oleg Nesterov X-Spam-Relay-Country: X-Spam-Timing: total 147 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.2 (2.2%), b_tie_ro: 2.2 (1.5%), parse: 0.71 (0.5%), extract_message_metadata: 11 (7.7%), get_uri_detail_list: 0.92 (0.6%), tests_pri_-1000: 6 (3.8%), tests_pri_-950: 1.24 (0.8%), tests_pri_-900: 1.04 (0.7%), tests_pri_-400: 15 (10.3%), check_bayes: 14 (9.6%), b_tokenize: 4.4 (3.0%), b_tok_get_all: 4.1 (2.8%), b_comp_prob: 1.49 (1.0%), b_tok_touch_all: 2.4 (1.7%), b_finish: 0.58 (0.4%), tests_pri_0: 102 (69.6%), check_dkim_signature: 0.43 (0.3%), check_dkim_adsp: 2.5 (1.7%), tests_pri_500: 3.8 (2.6%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH v5 4/6] fork: Skip setting TIF_SIGPENDING in ptrace_init_task X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code in calculate_sigpending will now handle this so it is just redundant and possibly a little confusing to continue setting TIF_SIGPENDING in ptrace_init_task. Suggested-by: Oleg Nesterov Signed-off-by: "Eric W. Biederman" --- include/linux/ptrace.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/ptrace.h b/include/linux/ptrace.h index 037bf0ef1ae9..4f36431c380b 100644 --- a/include/linux/ptrace.h +++ b/include/linux/ptrace.h @@ -214,8 +214,6 @@ static inline void ptrace_init_task(struct task_struct *child, bool ptrace) task_set_jobctl_pending(child, JOBCTL_TRAP_STOP); else sigaddset(&child->pending.signal, SIGSTOP); - - set_tsk_thread_flag(child, TIF_SIGPENDING); } else child->ptracer_cred = NULL; -- 2.17.1