Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Aug 2018 15:33:00 +0800
From:   Alan Kao <alankao@andestech.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     <vincentc@andestech.com>, Andrew Waterman <andrew@sifive.com>,
        "Arnd Bergmann" <arnd@arndb.de>, <greentime@andestech.com>,
        <zong@andestech.com>, Darius Rad <darius@bluespec.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        <linux-kernel@vger.kernel.org>, Albert Ou <albert@sifive.com>,
        <linux-riscv@lists.infradead.org>, <nickhu@andestech.com>
Subject: Re: [PATCH v5 5/5] Auto-detect whether a FPU exists
Message-ID: <20180809073300.GB18746@andestech.com>
References: <1533796003-680-1-git-send-email-alankao@andestech.com>
 <1533796003-680-6-git-send-email-alankao@andestech.com>
 <20180809063124.GA26062@infradead.org>
 <20180809064336.GA18746@andestech.com>
 <20180809070258.GA11082@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20180809070258.GA11082@infradead.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 09, 2018 at 12:02:58AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 09, 2018 at 02:43:36PM +0800, Alan Kao wrote:
> > It does look a little bit weird.  Should I send a v6 for this?
> 
> Yes, please resend the series or just this patch.
> 
> I think the hswap.h definition should go away and we should just
> keep the switch_to.h one, even if that means including the header
> in another C file.
> 

It turns out that only cpufeature.c and switch_to.h are affected
by hwcap.h.  As switch_to.h already had extern has_fpu declaration,
the one in hwcap.h is redundant and can be removed safely.

I will resend just this patch, and mark it as v6.