Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1780179imm; Thu, 9 Aug 2018 01:41:03 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx6NJsEWxi/lwyAekJ92cPrzeBjP62pWJM8nMQ/uk5t/EUogFbVFEgfsy0gn2U067nXGWrx X-Received: by 2002:a17:902:bd44:: with SMTP id b4-v6mr1246225plx.144.1533804063595; Thu, 09 Aug 2018 01:41:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533804063; cv=none; d=google.com; s=arc-20160816; b=PyblQqiDnFR1BQjhjxnkzyy384x23B7NrPRKQDGL93XS1VIrT8XbRx9jOts+0wi8wa QDWFF8CYZPJML1d4ut69U0IYT+wE1gZWaXXyFqDrrugaLHGub5zySkmaVp396Yd/cqWN PndpVDopbQIk/jbmvpLzJ0/xnqUuPsdSA7E/DnII9QG7TVzesMXUtUKu8hJzzElGEHvt r+2bmQpMLVrqQmGD6EHMfc3SJub33ZBNtZ6Gzld8BMowwSg8udIlozdhBQ3FOM4pnLFn sZV/WzE90CpnTvbjgfcXBYvlphaIr8OGMrqrUgI4wLOuG/ewuGig0UO9YE88UTt6VOVA m5Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+8PdsQaWxaEXlyd6GTGl+wQuViSbJVi2kbQMzWkdn9Q=; b=oJSIofXMPwU3zGSBWYWzNSo9kUFgQCISikInZwiNqPhF6bkMf/JlPeLab8VbqKVcgQ B14j0vh9eJoXYBB/RQ/cvNmOiWNS4HorWTWNwiHgSRI1hKeVRLPHZ7nCcNPDJcoHa973 XSsTEAF/J/F9y60BOmMwNU+9htR3MKthknirITh5fh8zkzr1+VuDwKiSAz3xBEEsOrFK vqKsXzB4kdALEDiSqkXtoKUgcQt5P2zFps2b7GSeEpeb/03b43ht/mNhjWw4PbKpq3q0 F5ttq6tAbrqA2kNHO2mJy4nNeI6/jFG/w+q2gqMgDA5f0Q100d95HpScJabv+ExEY4zk os9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9-v6si5864231pfe.11.2018.08.09.01.40.48; Thu, 09 Aug 2018 01:41:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729941AbeHILDq (ORCPT + 99 others); Thu, 9 Aug 2018 07:03:46 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:50198 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727371AbeHILDq (ORCPT ); Thu, 9 Aug 2018 07:03:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07CC018A; Thu, 9 Aug 2018 01:39:59 -0700 (PDT) Received: from darkstar (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B7EE3F5D0; Thu, 9 Aug 2018 01:39:54 -0700 (PDT) Date: Thu, 9 Aug 2018 09:39:47 +0100 From: Patrick Bellasi To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v3 01/14] sched/core: uclamp: extend sched_setattr to support utilization clamping Message-ID: <20180809083947.2ogkudkpg6d52roc@darkstar> References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-2-patrick.bellasi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-Aug 09:50, Randy Dunlap wrote: > Hi, Hi Randy, > On 08/06/2018 09:39 AM, Patrick Bellasi wrote: > > diff --git a/init/Kconfig b/init/Kconfig > > index 041f3a022122..1d45a6877d6f 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -583,6 +583,25 @@ config HAVE_UNSTABLE_SCHED_CLOCK > > config GENERIC_SCHED_CLOCK > > bool > > > > +menu "Scheduler features" > > + > > +config UCLAMP_TASK > > + bool "Enable utilization clamping for RT/FAIR tasks" > > + depends on CPU_FREQ_GOV_SCHEDUTIL > > + default false > > default n > but just omit the line completely since "n" is already the default. Right, will update for next posting! Is there a strict rule to omit this line when it's already the default? > > > + help > > + This feature enables the scheduler to track the clamped utilization > > + of each CPU based on RUNNABLE tasks currently scheduled on that CPU. > > + > > + When this option is enabled, the user can specify a min and max CPU > > + bandwidth which is allowed for a task. > > + The max bandwidth allows to clamp the maximum frequency a task can > > + use, while the min bandwidth allows to define a minimum frequency a > > + task will always use. > > Please clean up the indentation above to use one tab + 2 spaces on all lines. Sure, my bad I did not notice it... although I'm quite sure the patch passed a checkpatch... will check better next time. > > + > > + If in doubt, say N. > > + > > +endmenu Cheers Patrick -- #include Patrick Bellasi