Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1804737imm; Thu, 9 Aug 2018 02:11:31 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzk5MC1In+hxOn+Tq9Forj98zO64cARReQlNabV/gI3o30uL6K9f7d+Gzr7DEss5EiDjpKL X-Received: by 2002:a17:902:25ab:: with SMTP id y40-v6mr1351517pla.120.1533805891111; Thu, 09 Aug 2018 02:11:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533805891; cv=none; d=google.com; s=arc-20160816; b=etOILOw2LjnFa8QDj/pvEMMrAGcXCfOiocbwJmMzXDDptHTOgLVoB11rW4dNsPtmdH Djm6B5MYHzEQkWFXkUyDf2w+BxOOMYW0h9yk7ckmWvRzOVPyoXy1AWkfdI6xaHCFQ47w OwLFjoKvKiJmm5ypaIooZvGKIE4OVaJM6Kp6JlqiBQYp/nuoWI8FVTy+++bEXw84d3Ms BiFpz6waXLwd8ulA6S9aB7e4MyooD0xfwXWTEqq/Z2MXvDXF6K4ucNEmoiFt7PAou3jC lzljKI5D/9PUTCNuJNFOHOcA29N8LO9gufH9vyRO0YDuq9Kygt5hpdbsbbnraXwJCG0S P/Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=O4KQ004DmctuyGNJROfl3mJG4EK1yGROgs+qqP+3eoY=; b=CzjDBbpIUMgguzyePBOBrC81B4atKMXSnkwwJwOTNrE2phQQw4elQRVCecAkRCCPsk DVnpSiBGzgQzNSCzxI4YfLfjwApcpztKm6/gOM34BEg4juUjRcBGIUBarXxYnJ93eBi5 JtNR0Qk4NBrNRGGe+POdowWptAJRZlUyRP+Eaiv6uBAFA5JAhGTjyfGDeuIi2MHFyJN3 Zvq6Wdf525KkYr9JXtpxS17+DWNybKhf/FDl1/EYAqtxEgDwA4O4bSSCHbeCsSXBTrf9 R3NUV0oT2ZVlJFluMaluxSUd7mlQhv18V/Tf2t35JGP54hOWlzmrMf9wRrOQZi5fcfNQ 5fhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=UH+rS9w6; dkim=pass header.i=@codeaurora.org header.s=default header.b="Tnl/liYy"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i61-v6si5158101plb.209.2018.08.09.02.11.16; Thu, 09 Aug 2018 02:11:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=UH+rS9w6; dkim=pass header.i=@codeaurora.org header.s=default header.b="Tnl/liYy"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729872AbeHILeV (ORCPT + 99 others); Thu, 9 Aug 2018 07:34:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55568 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727371AbeHILeV (ORCPT ); Thu, 9 Aug 2018 07:34:21 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 074CB60B7E; Thu, 9 Aug 2018 09:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533805826; bh=hBRgRdF6CiGcJFfgPR0p7wegHhaSfCOrYBNWbPs6Hbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UH+rS9w6rRw1Wp7aU0WTgdz9AyxIGDBB5ZzLmpU3TFwZz2wKfY4kSVlYErpGcKP9O LBgR5RBh+rC4HEVW6H9ODWUOZoBmHLUxN147t1iuXepF99eexwt+r9kYe8nLjlzhpx PGcbar1Hz9Ka3sXOhTyYNLHnemCPfCqKzVN/u1YY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from sayalil-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sayalil@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 097FE60115; Thu, 9 Aug 2018 09:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533805824; bh=hBRgRdF6CiGcJFfgPR0p7wegHhaSfCOrYBNWbPs6Hbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tnl/liYylp3f1GikmjDl/3NdsztB9ZgTjJFkpE4/c195xDB3FmYriajpyu5mbmhzs gAx8dJ0qQSPRY5Z3ttmNybW/mrJYF5qoVin1zPjhJ4aCgM92xkakidaeFLS3j+Nujj jLHA1kUXBLE8OPfjtVit1yTqGaFolF4p2DJXT4fs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 097FE60115 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sayalil@codeaurora.org From: Sayali Lokhande To: subhashj@codeaurora.org, cang@codeaurora.org, vivek.gautam@codeaurora.org, rnayak@codeaurora.org, vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, asutoshd@codeaurora.org, evgreen@chromium.org, riteshh@codeaurora.org Cc: adrian.hunter@intel.com, linux-scsi@vger.kernel.org, Sayali Lokhande , linux-kernel@vger.kernel.org (open list) Subject: [PATCH V8 1/2] scsi: ufs: set the device reference clock setting Date: Thu, 9 Aug 2018 14:39:58 +0530 Message-Id: <1533805799-5831-2-git-send-email-sayalil@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1533805799-5831-1-git-send-email-sayalil@codeaurora.org> References: <1533805799-5831-1-git-send-email-sayalil@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Subhash Jadavani UFS host supplies the reference clock to UFS device and UFS device specification allows host to provide one of the 4 frequencies (19.2 MHz, 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the device reference clock frequency setting in the device based on what frequency it is supplying to UFS device. Signed-off-by: Subhash Jadavani Signed-off-by: Can Guo Signed-off-by: Sayali Lokhande --- drivers/scsi/ufs/ufs.h | 21 ++++++++++ drivers/scsi/ufs/ufshcd-pltfrm.c | 2 + drivers/scsi/ufs/ufshcd.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.h | 2 + 4 files changed, 114 insertions(+) diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 14e5bf7..c555ac0 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -378,6 +378,27 @@ enum query_opcode { UPIU_QUERY_OPCODE_TOGGLE_FLAG = 0x8, }; +/* bRefClkFreq attribute values */ +enum ref_clk_freq_hz { + REF_CLK_FREQ_19_2_MHZ = 19200000, + REF_CLK_FREQ_26_MHZ = 26000000, + REF_CLK_FREQ_38_4_MHZ = 38400000, + REF_CLK_FREQ_52_MHZ = 52000000, +}; + +enum bref_clk_freq { + bREF_CLK_FREQ_0, /* 19.2 MHz */ + bREF_CLK_FREQ_1, /* 26 MHz */ + bREF_CLK_FREQ_2, /* 38.4 MHz */ + bREF_CLK_FREQ_3, /* 52 MHz */ + bREF_CLK_FREQ_INVAL, +}; + +struct ufs_ref_clk { + enum ref_clk_freq_hz freq_hz; + enum bref_clk_freq val; +}; + /* Query response result code */ enum { QUERY_RESULT_SUCCESS = 0x00, diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index e82bde0..0953563 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -343,6 +343,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); + ufshcd_parse_dev_ref_clk_freq(hba); + ufshcd_init_lanes_per_dir(hba); err = ufshcd_init(hba, mmio_base, irq); diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index c5b1bf1..0cbdde7 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6296,6 +6296,89 @@ static void ufshcd_def_desc_sizes(struct ufs_hba *hba) hba->desc_size.hlth_desc = QUERY_DESC_HEALTH_DEF_SIZE; } +static struct ufs_ref_clk ufs_ref_clk_freqs[] = { + {REF_CLK_FREQ_19_2_MHZ, bREF_CLK_FREQ_0}, + {REF_CLK_FREQ_26_MHZ, bREF_CLK_FREQ_1}, + {REF_CLK_FREQ_38_4_MHZ, bREF_CLK_FREQ_2}, + {REF_CLK_FREQ_52_MHZ, bREF_CLK_FREQ_3}, +}; + +static inline enum bref_clk_freq +ufs_get_bref_clk_for_ref_clk_freq_hz(u32 freq) +{ + enum bref_clk_freq val; + + for (val = bREF_CLK_FREQ_0; val <= bREF_CLK_FREQ_3; val++) + if (ufs_ref_clk_freqs[val].freq_hz == freq) + return val; + + /* if no match found, return invalid*/ + return bREF_CLK_FREQ_INVAL; +} + +void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba) +{ + struct device *dev = hba->dev; + struct device_node *np = dev->of_node; + struct clk *refclk = NULL; + u32 freq = 0; + + if (!np) + return; + + hba->dev_ref_clk_freq = bREF_CLK_FREQ_INVAL; + + refclk = of_clk_get_by_name(np, "ref_clk"); + if (!refclk) + return; + + freq = clk_get_rate(refclk); + if (freq > REF_CLK_FREQ_52_MHZ) { + dev_err(hba->dev, + "%s: invalid ref_clk setting = %d\n", + __func__, freq); + return; + } + + hba->dev_ref_clk_freq = + ufs_get_bref_clk_for_ref_clk_freq_hz(freq); +} + +static int ufshcd_set_dev_ref_clk(struct ufs_hba *hba) +{ + int err = 0; + int ref_clk = -1; + + err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR, + QUERY_ATTR_IDN_REF_CLK_FREQ, 0, 0, &ref_clk); + + if (err) { + dev_err(hba->dev, "%s: failed reading bRefClkFreq. err = %d\n", + __func__, err); + goto out; + } + + if (ref_clk == hba->dev_ref_clk_freq) + goto out; /* nothing to update */ + + err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR, + QUERY_ATTR_IDN_REF_CLK_FREQ, 0, 0, + &hba->dev_ref_clk_freq); + + if (err) + dev_err(hba->dev, "%s: bRefClkFreq setting to %d Hz failed\n", + __func__, ufs_ref_clk_freqs[hba->dev_ref_clk_freq].freq_hz); + /* + * It is good to print this out here to debug any later failures + * related to gear switch. + */ + dev_dbg(hba->dev, "%s: bRefClkFreq setting to %d Hz succeeded\n", + __func__, ufs_ref_clk_freqs[hba->dev_ref_clk_freq].freq_hz); + +out: + return err; +} + /** * ufshcd_probe_hba - probe hba to detect device and initialize * @hba: per-adapter instance @@ -6361,6 +6444,12 @@ static int ufshcd_probe_hba(struct ufs_hba *hba) "%s: Failed getting max supported power mode\n", __func__); } else { + /* + * Set the right value to bRefClkFreq before attempting to + * switch to HS gears. + */ + if (hba->dev_ref_clk_freq < bREF_CLK_FREQ_INVAL) + ufshcd_set_dev_ref_clk(hba); ret = ufshcd_config_pwr_mode(hba, &hba->max_pwr_info.info); if (ret) { dev_err(hba->dev, "%s: Failed setting power mode, err = %d\n", diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index 8110dcd..101a75c 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -548,6 +548,7 @@ struct ufs_hba { void *priv; unsigned int irq; bool is_irq_enabled; + u32 dev_ref_clk_freq; /* Interrupt aggregation support is broken */ #define UFSHCD_QUIRK_BROKEN_INTR_AGGR 0x1 @@ -746,6 +747,7 @@ static inline void ufshcd_rmwl(struct ufs_hba *hba, u32 mask, u32 val, u32 reg) int ufshcd_wait_for_register(struct ufs_hba *hba, u32 reg, u32 mask, u32 val, unsigned long interval_us, unsigned long timeout_ms, bool can_sleep); +void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba); static inline void check_upiu_size(void) { -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project