Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1981851imm;
        Thu, 9 Aug 2018 05:30:34 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPwxLEk5KZZlmWC6iFgyCm2ybb5awjl39Wurq8qfBU9Zz7VAFTqwS6EqIK8fUCV7UL3+wwq4
X-Received: by 2002:a17:902:530a:: with SMTP id b10-v6mr1946347pli.101.1533817834534;
        Thu, 09 Aug 2018 05:30:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1533817834; cv=none;
        d=google.com; s=arc-20160816;
        b=dA6HPz+8NnTJctIVdZl/UM64GeWtIgXy6uCK5bC/+UHg4Zq0wQCwX2KGkeFt3/Totq
         z983y7fmnFJqfF+Uhl7skj18Xu0HSi7vhvwzxzGvdNwI0e4neDxKP5tE23C4JTqSfNKL
         AAXqz/A8+wYuniLhqJxdYIW5tH7+NCSjm9OxuzzjNzar4OD1vvTHFu8HfBRyxw4rJzO4
         pFmUo33q8UtYi0fCp108NcR2vU3/MSdnWwJeIpP+Tv/6GrRQNEjCKKushRaMw0G4Pnjl
         c9OsIDj1K1ahHWaCDZZGbXSQmMtp/Eq0uNMw4CHWvs3786dYcI4WW9y/4qtQzvnYdKIg
         NRGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :arc-authentication-results;
        bh=LU9oplKBWrQaJ0Ud48Hw1syXNDBeW5frvoKhM2LxRdY=;
        b=m9Za4aOkrocAfyFLXEUPgIUg5nG/J2OsJ8oTasUaGsqHcwejYtZGdACqIyWgYpOJ88
         zZdrw+S3mw0xpEi/3UQFgq23OoDvnmLISUl4W06UGbvwf/ot3Fj7lQv7HdDQYv6rX1qr
         /BBe/whT1oqjM9+Qk7bA+zp8I7aHCwM8oPOworIWUboowQGGYcKeyvJy8KiQssC1xjsI
         MSTzwW5HUP47d2KBz9wK+yQjc/cZF/zFj/7fL2CopzlvoeI92cjc70Qm5rrXXshEcmR9
         76iSFOR2pBd1gbvnx+3FLrFZe+FLFShX/nBQiGGegvvw9vWTbqLB5aXgtmxApmONb1o+
         oibA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f17-v6si6817464pgl.59.2018.08.09.05.30.19;
        Thu, 09 Aug 2018 05:30:34 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730839AbeHIOyI (ORCPT <rfc822;marvinzhang.kernel@gmail.com>
        + 99 others); Thu, 9 Aug 2018 10:54:08 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:19300 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727786AbeHIOyH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Aug 2018 10:54:07 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b6c33a40001>; Thu, 09 Aug 2018 05:29:24 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Thu, 09 Aug 2018 05:29:21 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Thu, 09 Aug 2018 05:29:21 -0700
Received: from dhcp-10-21-25-168 (10.21.25.201) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 9 Aug
 2018 12:29:24 +0000
Date:   Thu, 9 Aug 2018 15:29:18 +0300
From:   Aapo Vienamo <avienamo@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Mikko Perttunen" <mperttunen@nvidia.com>,
        <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/8] mmc: tegra: Implement HS400 delay line calibration
Message-ID: <20180809152918.4a3e7060@dhcp-10-21-25-168>
In-Reply-To: <20180809114805.GM21639@ulmo>
References: <1533650404-18125-1-git-send-email-avienamo@nvidia.com>
        <1533650404-18125-5-git-send-email-avienamo@nvidia.com>
        <20180809114805.GM21639@ulmo>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.21.25.201]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To HQMAIL101.nvidia.com
 (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 9 Aug 2018 13:48:05 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:

> On Tue, Aug 07, 2018 at 05:00:00PM +0300, Aapo Vienamo wrote:
> > Implement HS400 specific delay line calibration procedure.
> > 
> > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> > ---
> >  drivers/mmc/host/sdhci-tegra.c | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)  
> 
> Should this be before the previous patch in order to make sure the
> calibration is performed as soon as the feature is available. This is
> counting beans I guess, but it is technically possible for someone to
> get everything up to patch 3/8 and then get the corresponding changes
> in the DTS files to enable the mode and then have HS400 enabled without
> this calibration.

True.

> 
> > 
> > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> > index d81143b..d0b68b7 100644
> > --- a/drivers/mmc/host/sdhci-tegra.c
> > +++ b/drivers/mmc/host/sdhci-tegra.c
> > @@ -56,6 +56,12 @@
> >  #define SDHCI_MISC_CTRL_ENABLE_SDHCI_SPEC_300		0x20
> >  #define SDHCI_MISC_CTRL_ENABLE_DDR50			0x200
> >  
> > +#define SDHCI_TEGRA_VENDOR_DLLCAL_CFG			0x1b0
> > +#define SDHCI_TEGRA_DLLCAL_CALIBRATE			BIT(31)
> > +
> > +#define SDHCI_TEGRA_VENDOR_DLLCAL_STA			0x1bc
> > +#define SDHCI_TEGRA_DLLCAL_STA_ACTIVE			BIT(31)
> > +
> >  #define SDHCI_VNDR_TUN_CTRL0_0				0x1c0
> >  #define SDHCI_VNDR_TUN_CTRL0_TUN_HW_TAP			0x20000
> >  
> > @@ -584,6 +590,24 @@ static void tegra_sdhci_set_dqs_trim(struct sdhci_host *host, u8 val)
> >  	sdhci_writel(host, reg, SDHCI_TEGRA_VENDOR_CAP_OVERRIDES);
> >  }
> >  
> > +static void tegra_sdhci_hs400_dll_cal(struct sdhci_host *host)
> > +{
> > +	u32 reg;
> > +	int err;
> > +
> > +	reg = sdhci_readl(host, SDHCI_TEGRA_VENDOR_DLLCAL_CFG);
> > +	reg |= SDHCI_TEGRA_DLLCAL_CALIBRATE;
> > +	sdhci_writel(host, reg, SDHCI_TEGRA_VENDOR_DLLCAL_CFG);  
> 
> Is this self-clearing? Or do we need to clear it manually in order for
> a subsequent calibration procedure to succeed?

Yes, the TRM states that this bit should not be cleared by software.

 -Aapo