Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1990836imm;
        Thu, 9 Aug 2018 05:38:56 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPx6iZjNG0a/1W4HAc4jjeshYsxdZBeWn9wjBvoIagQAGyWZWYhDgOsLrD1H57jufaWGYjVu
X-Received: by 2002:a62:25c5:: with SMTP id l188-v6mr2209683pfl.179.1533818336346;
        Thu, 09 Aug 2018 05:38:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1533818336; cv=none;
        d=google.com; s=arc-20160816;
        b=e/ZNm/iMFGyFa+or5Gg/jhUIwt7laru5NWdr4R2amHH6FGvlHZClEIiPxNhmg4m3+t
         WfV5xo4tLA6SjVv+pcyWGQ+5+/vkjd/pzn78c5hWDjenfEB7+ch3aBhnpqUmjEFoKU9V
         c9j2/at+rrjWFg6y3w6gMctwClL4G3A20PKpHt2A7JvcaQyp7pG2jDDvOv6dz7ErABY8
         Dvh4RL7LKaTio7n/Tp5rvw5URN5Xxdno1c4ozbn2w8pIOMBcTYPxi67SrA2lNn1yqLfy
         IT2lRI1PUAWwLKg/LoG2PDKeLk22xUxdVvxd1Qm0iwtsmncFuRpDBemUUekr4U/BjJOV
         LPTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :arc-authentication-results;
        bh=M8B22dCj3LJ18AyCaoBrc0+gX45Uj2Tc5b7Y4AcOTFQ=;
        b=jB5mkG6S7G7sVs7ByTG2qn3S6XBYtatax1ImKys/BQVa4NmhRTdEviST0cuY+9+X5D
         LgebUhQBz1k40p+cmupeasn0BUQCOP72bQf+t7f2g2UJp7c6u2Zqh4ULmDjTRvzprdKt
         HaKVcl3cA8iTQc/2LMqf7wtcnI8oWXOxq10J3f+YnC2k5VwhhxWNRCRuGMUbJWXqYO9Z
         aSksJCaagAKjUMiVOAW8NP/uNmx0mkT0GMygIN0sTgVTAMX0XKPhxSbwlfnsL0wXzAok
         JtvJ0v7LxfpaeKd45Otntuwh7BFG/RqoXnuMK5FqWAxqNwBoFvlU1qMAqdBWFcHJ9Fp4
         qipQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id r16-v6si6864827pgg.254.2018.08.09.05.38.41;
        Thu, 09 Aug 2018 05:38:56 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732232AbeHIPCY (ORCPT <rfc822;marvinzhang.kernel@gmail.com>
        + 99 others); Thu, 9 Aug 2018 11:02:24 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:15564 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730506AbeHIPCY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Aug 2018 11:02:24 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b6c35880000>; Thu, 09 Aug 2018 05:37:28 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 09 Aug 2018 05:37:41 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 09 Aug 2018 05:37:41 -0700
Received: from dhcp-10-21-25-168 (10.21.25.201) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 9 Aug
 2018 12:37:38 +0000
Date:   Thu, 9 Aug 2018 15:37:32 +0300
From:   Aapo Vienamo <avienamo@nvidia.com>
To:     Peter Geis <pgwipeout@gmail.com>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "Adrian Hunter" <adrian.hunter@intel.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/8] arm64: dts: tegra186: Add SDMMC4 DQS trim value
Message-ID: <20180809153732.4c91e425@dhcp-10-21-25-168>
In-Reply-To: <03fc6726-25ff-20de-d271-ebae19b753c7@gmail.com>
References: <1533650404-18125-1-git-send-email-avienamo@nvidia.com>
        <1533650404-18125-6-git-send-email-avienamo@nvidia.com>
        <20180809114922.GN21639@ulmo>
        <20180809150226.64657f56@dhcp-10-21-25-168>
        <03fc6726-25ff-20de-d271-ebae19b753c7@gmail.com>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.21.25.201]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To HQMAIL101.nvidia.com
 (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 9 Aug 2018 08:23:16 -0400
Peter Geis <pgwipeout@gmail.com> wrote:

> On 08/09/2018 08:02 AM, Aapo Vienamo wrote:
> > On Thu, 9 Aug 2018 13:49:22 +0200
> > Thierry Reding <thierry.reding@gmail.com> wrote:
> >   
> >> On Tue, Aug 07, 2018 at 05:00:01PM +0300, Aapo Vienamo wrote:  
> >>> Add the HS400 DQS trim value for Tegra186 SDMMC4.
> >>>
> >>> Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> >>> ---
> >>>   arch/arm64/boot/dts/nvidia/tegra186.dtsi | 1 +
> >>>   1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> >>> index 6e9ef26..9e07bc6 100644
> >>> --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> >>> +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> >>> @@ -313,6 +313,7 @@
> >>>   		nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>;
> >>>   		nvidia,default-tap = <0x5>;
> >>>   		nvidia,default-trim = <0x9>;
> >>> +		nvidia,dqs-trim = <63>;
> >>>   		status = "disabled";
> >>>   	};
> >>>       
> >>
> >> Isn't this technically dependent on the board layout and as such would
> >> belong in the board DTS file? Or does this value work on all existing
> >> Tegra186 platforms?  
> > 
> > This value is specified as part of the controller initialization
> > sequence in the TRM. I've understood that this (and other tap and trim)
> > value(s) are used for compensating the propagation delay differences
> > that are caused by the internal SoC layout.
> > 
> >   -Aapo
> > --  
> 
> The Tegra2 and Tegra3 TRMs also specify recommended DQS values, and I am 
> working on at least one device that differs in the platform data from 
> the default value.
> I see that you mentioned this is for the newer devices that support 
> HS200/HS400 modes, but does it enable setting DQS on older devices?

I can't find any mention of _SDMMC_ DQS trimmer on Tegra2, Tegra3 or
Tegra124 TRMs. As far as I can tell, programming the DQS trimmer value
is only required by HS400 signaling on Tegra210 and Tegra186.

 -Aapo