Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1996771imm;
        Thu, 9 Aug 2018 05:45:29 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPw3rT3C9FItZ61cUwiJhhDFrF+e12CINa3ODSCwRejY5ZFKYhzrLkE8rpuu8HjAb19CM0Yw
X-Received: by 2002:a62:4bc6:: with SMTP id d67-v6mr2219226pfj.175.1533818729134;
        Thu, 09 Aug 2018 05:45:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1533818729; cv=none;
        d=google.com; s=arc-20160816;
        b=RYZbsAqWcZ1cc+RJxfZ2heiG51WsfVpZQoph9EciuQoCGrZYV1jUIgahfJ8NWL+t9s
         +ErJ5/IYuUmXJE53yc8XL5icipyiy6hG47P0pGpHejrGrbJvPUrUsyas9/pPJTZhoPb2
         KbEORZVyi5AQuCBe2eVAJSl0fHU1e5Eg4cfRs9UzaUuaHVZLTYl76/3u53YCtdKkMmfu
         YtggDIo58BDISZCG5UTcHQDVg66coQ/5pdXQ9qKEigOkavCH02rDu+LG1mWbkCm9CPws
         Z1QRVy3UIkHERp2wQqcFy1hrJuruWd8oYoK17A8YPTvQwZ9F9Xv1+/HPMfL3Ui9f3b0F
         5yGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :arc-authentication-results;
        bh=w8M8zOdqCD2P5deyMOPjPMDuuV/UJlQpuyDTaqJ74C4=;
        b=YBZV++W+r7eO4x9qqp3mbDxIZVkkEMvy1hURHKskQ7k6fwkKMDljIJXXIPh/pqVTMf
         WbMvibCH8A3njcsU9BJLlWIbmngR/XmOWj4rrgcqwHG0qn4bh4ojNhWqFdnY7FaatOWZ
         FgZmrAe6SQA66fu8ppM7Kv0be3l1ir5NZNk6EO2i3YjSlPaWCOjwamX5HeTdvyVdS1IF
         wtK42+flvxQKwSVP0VrhBdVkKLnyjb7lWITtI85pjefm3W/QDVTJyuy6P16jRYeN3FGT
         /T8Hb6wMbQSne3mQBTZjBITskA/V20z0E5foIscu8tVod8GkxF72nFUz+R2i52067a0n
         /Kfw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id u190-v6si7160694pgu.305.2018.08.09.05.45.14;
        Thu, 09 Aug 2018 05:45:29 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731665AbeHIPJG (ORCPT <rfc822;marvinzhang.kernel@gmail.com>
        + 99 others); Thu, 9 Aug 2018 11:09:06 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:15795 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730090AbeHIPJG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Aug 2018 11:09:06 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b6c37180000>; Thu, 09 Aug 2018 05:44:08 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Thu, 09 Aug 2018 05:44:16 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Thu, 09 Aug 2018 05:44:16 -0700
Received: from dhcp-10-21-25-168 (10.21.25.201) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 9 Aug
 2018 12:44:18 +0000
Date:   Thu, 9 Aug 2018 15:44:12 +0300
From:   Aapo Vienamo <avienamo@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Mikko Perttunen" <mperttunen@nvidia.com>,
        Stefan Agner <stefan@agner.ch>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 10/40] soc/tegra: pmc: Implement pad configuration via
 pinctrl
Message-ID: <20180809154412.4e7fe9b3@dhcp-10-21-25-168>
In-Reply-To: <20180809122706.GT21639@ulmo>
References: <1533141150-10511-1-git-send-email-avienamo@nvidia.com>
        <1533141150-10511-11-git-send-email-avienamo@nvidia.com>
        <20180809122706.GT21639@ulmo>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.21.25.201]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To HQMAIL101.nvidia.com
 (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 9 Aug 2018 14:27:06 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:

> On Wed, Aug 01, 2018 at 07:32:00PM +0300, Aapo Vienamo wrote:
> > Register a pinctrl device and implement get and set functions for
> > PIN_CONFIG_LOW_POWER_MODE and PIN_CONFIG_POWER_SOURCE parameters.
> > 
> > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> > Acked-by: Jon Hunter <jonathanh@nvidia.com>
> > ---
> >  drivers/soc/tegra/pmc.c | 187 +++++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 185 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c  
> [...]
> > @@ -1704,6 +1863,12 @@ static const u8 tegra124_cpu_powergates[] = {
> >  		.name	= (_name),			\
> >  	})
> >  
> > +#define TEGRA_IO_PIN_DESC(_id, _dpd, _voltage, _name)	\
> > +	((struct pinctrl_pin_desc) {			\
> > +		.number = (_id),			\
> > +		.name	= (_name)			\
> > +	})
> > +  
> 
> Do we really need the explicit cast to struct pinctrl_pin_desc here?
> 

No, but I prefer to have it as it makes the type of the value the macro
expands to explicit. In a way it hints at how and where the macro should
be used and arguably improves readability.

 -Aapo