Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2162436imm; Thu, 9 Aug 2018 08:16:56 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw+eTIgYQKCKHpzPSFF4FqL5Q4oMG/gxTo7nqnKbhqcWQ5+aolvQ6vmKZ91gXAniVw9PJhC X-Received: by 2002:a62:6746:: with SMTP id b67-v6mr2802692pfc.243.1533827816634; Thu, 09 Aug 2018 08:16:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533827816; cv=none; d=google.com; s=arc-20160816; b=CaluXbCFpk5ldXHVbAxLCbY0sonBi8rGRbb3E5Ay1GmTL2cgc9CStyJjuApdwVSfQ2 ATZuD9tavMnI8/pHz8pbeEUBY4MV/vxUfV+Sxh0c/5yyFl767KGKTimkfCVhD+1CDfXS VIF/BUM1XTYVF3/ED7buNZEom6XdC4kwe3XLS+fx3g51vxN4T0FruNngZNr3FYvBKopn 9yLUo/A1MVva1N6OmA7J56zPZAItfj39g2TRzyyTUA+W1kYTMaKR2Ej41ZYNxBjTly3R ozSx7ZIHiXt/m5SoPVGYi4XjicdmBYxSzM0H/TPlEU0Q75XrsQKXq+DzO8jRFsnSOZ/Z dUlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=jG9du+dvyib93l4GGaZqJCFP3D1PmxvpPfbsdRRl76o=; b=Twdal41vtyL+SONfQfcKaGJ7P3FQApW2o4LYPXcbcL8Ib7CKmJanhC3P22BleSyFcB 2tKVSQ4uv53zFp6g2hYs1JcTK+GxIQEPUsoiBhW4MZM+tGwaj488fZBnlhdW7rH7fsWQ b3ZrhMOIlNfLn4fUaNnqQgg1eAGd1madyQ/ev04kJzs79PaBjRZsUDaK+ZbJiyGIoUl5 KYtYvIrmMRORTWb/7dCStDJMsJL65UlRQYvtfw/JsT3eKohqvbN55LSZT9bQ7tLAaCr9 eEvBynzw0CCE7+HjAAdGWVbOtfPQ7SdebBaJYtTCne4EhXbfK97lEgpcAg7vNfEAp8Ze /Q1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=WUcknWNm; dkim=pass header.i=@codeaurora.org header.s=default header.b=AC3z4UWx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11-v6si5798517pla.442.2018.08.09.08.16.41; Thu, 09 Aug 2018 08:16:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=WUcknWNm; dkim=pass header.i=@codeaurora.org header.s=default header.b=AC3z4UWx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732604AbeHIRko (ORCPT + 99 others); Thu, 9 Aug 2018 13:40:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46958 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731793AbeHIRko (ORCPT ); Thu, 9 Aug 2018 13:40:44 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C033760B7E; Thu, 9 Aug 2018 15:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533827721; bh=J6sNB0aHJREpuF+8k3zidbhYYBLRvQMlU9jjOmDXq70=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=WUcknWNm9Fhaf4Q9fa3KbNt/lcWpjWV++fPFUxfIHWQ7WvExuMBXSRsAScFiSbr7/ HaD2dh2RurqAC4I/mFSaYkp/XpP4ZlAOwWdiZhCLn7b4+V9yVU8uP31EPvhqsAHxUi wtN6t8f9/P1CybHFXtQnC+KaHN764FpUIcGnL5yY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C488460AD8; Thu, 9 Aug 2018 15:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533827720; bh=J6sNB0aHJREpuF+8k3zidbhYYBLRvQMlU9jjOmDXq70=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=AC3z4UWx12hPsAM5/8okCm1XV35lXeDQX8NyFBxbg9+6wXfFpPrX08/I6N/LNb74b fd6yqhqeMThYngt05o+UsG5IR/X/gqNvKGxXgfwAWaAVMWksP3O4dPGVMl/YpFqRcK 6hJqNHAq3dgQZP+nryqOpTT7CRSdKk+fZUJ7S28Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C488460AD8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: btcoex: Fix if == else warnings in halbtc8723b2ant.c From: Kalle Valo In-Reply-To: <20180806045440.11920-1-yuehaibing@huawei.com> References: <20180806045440.11920-1-yuehaibing@huawei.com> To: YueHaibing Cc: , , , , , , , YueHaibing User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180809151521.C033760B7E@smtp.codeaurora.org> Date: Thu, 9 Aug 2018 15:15:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing wrote: > Fix following coccinelle warning: > > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2952:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2961:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3011:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3020:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3439:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3448:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3339:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3348:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3074:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3083:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3192:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3201:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3267:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3276:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3124:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3133:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2821:2-4: WARNING: possible condition with no effect (if == else) > ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2830:2-4: WARNING: possible condition with no effect (if == else) > > Signed-off-by: YueHaibing > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. ad2e6d23bdad rtlwifi: btcoex: Fix if == else warnings in halbtc8723b2ant.c -- https://patchwork.kernel.org/patch/10556487/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches