Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2203114imm; Thu, 9 Aug 2018 08:57:12 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyJNKm/2nrXxbBQ627KoqwyeL45vFLqFAV7TyDfbGvLHZIpKRQXKR+PACEHYj6fWZ+r2ELq X-Received: by 2002:a63:f713:: with SMTP id x19-v6mr2692326pgh.233.1533830232309; Thu, 09 Aug 2018 08:57:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533830232; cv=none; d=google.com; s=arc-20160816; b=BRKl6n2og7O/G/zbqwis5A0iwo2smI5JKkCX33D2sC4QNQsKzPapfHN5vrd5eT6HLp nz1XgeCnpw1TKveMlUCn3S9BLOkYiyMv6ACyldcVGw5paqtCL+okaTpcuSGZTzARLJoV J662CYy36XwMaEPy4GnMQD+AKa7Pexp2r1M6/oopmG8FnC9bwxF/iet7HVReqxuZxZKp fv1/eDq0fGm1lWsrO245GBdgd4Hwo55Qze3sa1Ajri2EhmAdSZgPEW+26HHvDo3nw7lx 3hnXexbUBLothD8JMz/NAz8Ufr8/9DU36+WKYRmx36NCVRr0Mi+QadgVj7dYeiQtsCWH qvHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=ItqrPq/4rwtBO2Mz9vWY54I0oKedsGh7gByjfkEUfOY=; b=lqeRVbeZdw8aURXDLySXTcwmTlIrINzNAU8113+JhZ9Wi8LlEngx6PkegzxaxjCQ6h 5V97/iDMxNSCA9gF62AFLfO6RunYCECug3tPNWFc/zT4d2nr+xgzo4TmI9K1t8dHveZm ui5dC1gmLJWOjnPm1ABdE3keJCT58o9N6Z9/paA6CdFmV1/Kr3q92ojQNS7GrCCX8bE2 SQqRHe5MFpE0aOoOtLQniIL9Yeq1DzPXhyKzQhnU4ZdJ/aNdkzSsU0zFwKXY6lblEEHj 7K36L+AQG/ulScH+J3BmvUUHAgKJLJQAgz0FDYroQnIf9K29s7TjoKnoFvwXF81Jgw4s 9mtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si7796070pfb.262.2018.08.09.08.56.54; Thu, 09 Aug 2018 08:57:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732382AbeHISVX (ORCPT + 99 others); Thu, 9 Aug 2018 14:21:23 -0400 Received: from gateway33.websitewelcome.com ([192.185.146.130]:26321 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731957AbeHISVX (ORCPT ); Thu, 9 Aug 2018 14:21:23 -0400 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id E11D5152431 for ; Thu, 9 Aug 2018 10:55:51 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id nnHzf1vIUBcCXnnHzfbUTC; Thu, 09 Aug 2018 10:55:51 -0500 X-Authority-Reason: nr=8 Received: from [189.250.54.46] (port=51394 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fnnHz-002E2T-8G; Thu, 09 Aug 2018 10:55:51 -0500 Date: Thu, 9 Aug 2018 10:54:46 -0500 From: "Gustavo A. R. Silva" To: Tim Waugh , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] block: paride: pd: mark expected switch fall-throughs Message-ID: <20180809155446.GA19883@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.54.46 X-Source-L: No X-Exim-ID: 1fnnHz-002E2T-8G X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.54.46]:51394 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 20 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1056543 ("Missing break in switch") Addresses-Coverity-ID: 1056544 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/block/paride/pd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index 8961b190..7cf9475 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c @@ -426,6 +426,7 @@ static void run_fsm(void) pd_claimed = 1; if (!pi_schedule_claimed(pi_current, run_fsm)) return; + /* fall through */ case 1: pd_claimed = 2; pi_current->proto->connect(pi_current); @@ -445,6 +446,7 @@ static void run_fsm(void) spin_unlock_irqrestore(&pd_lock, saved_flags); if (stop) return; + /* fall through */ case Hold: schedule_fsm(); return; -- 2.7.4