Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2248059imm;
        Thu, 9 Aug 2018 09:37:28 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPwjJBaezwc+N882MtI/EvJ7xZk5OZ9TB6ZJCtVB8CLItgbwWwzhFLOyS8bL1zYhtndVtZ4L
X-Received: by 2002:a63:774c:: with SMTP id s73-v6mr2873250pgc.339.1533832648487;
        Thu, 09 Aug 2018 09:37:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1533832648; cv=none;
        d=google.com; s=arc-20160816;
        b=bvZPbphBZW7YA+I8cV1GxmLdq72kcAzC8p5gzsSU+GrZ8KjYKxWI5cnHvDHCRyJBLE
         /beAdTClZrS5oCwQ0zyr3eHQDkhHVghkoLM9/FFgLYOlq2kDBXIbr6rz61scy7zI7Td3
         t7EbibIVnu775o/6B+3RDcauIACgQh3YMapbNYXAtJNrWzv4PyqMbx6u6sPjZ8ZI0BYt
         fqcXhoHGeWpOa6aQpSQbYLRCU8o3tPzFTiWyCQRbmVJJz+AE2p6FeVyYR3chA+4Rtm3e
         dOZ6Ovq8wIlmfKl7cbtpJ0n/nkJg05Fc4JGKKVHk2dIFxffkmcBGHBXU/e71yZ67cKFg
         mzKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :arc-authentication-results;
        bh=cerJ33IlVpYumqsBeLGPBAnZ9tZbJ+INWaJgnfnn76M=;
        b=V/uM2xTPaAIxGyV/SZRog/hl43GOtOmTKKsVbxPCAk87dWrS5f0GVMZLfoJYjWjaBf
         6A/bPiWPYnAWosNW55SoQyrf86d7UxyDiFOc4ox5S3y0yQWmPJb9cYvCd+uwxse2T98j
         nrnFIFWlboriMqCpKxjEm0LxOkC9VXpgt0tvrNJfUdinWPbBq7Qm4+CUB/rHodbWKOG7
         /vKFitDOVDYpvrAGeYsmz3wpTXFMU/MIXqdBBEq+is2KYcKCEyA06MyEFm6YaqW1hfOR
         W2XD3W1oB/KhPXZlJu3Akggt0oEBNbcAB032VXzZ7BF5/RgrGo13uq+XhuWuo6D0sqpF
         XY6Q==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id ba6-v6si6003225plb.364.2018.08.09.09.37.13;
        Thu, 09 Aug 2018 09:37:28 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732536AbeHITCC (ORCPT <rfc822;charleyewang@gmail.com>
        + 99 others); Thu, 9 Aug 2018 15:02:02 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:8166 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732364AbeHITCC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Aug 2018 15:02:02 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b6c6d780000>; Thu, 09 Aug 2018 09:36:08 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 09 Aug 2018 09:36:22 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 09 Aug 2018 09:36:22 -0700
Received: from dhcp-10-21-25-168 (10.21.25.201) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 9 Aug
 2018 16:36:18 +0000
Date:   Thu, 9 Aug 2018 19:36:13 +0300
From:   Aapo Vienamo <avienamo@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Mikko Perttunen" <mperttunen@nvidia.com>,
        Stefan Agner <stefan@agner.ch>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 02/40] dt-bindings: mmc: tegra: Add pad voltage control
 properties
Message-ID: <20180809193613.5327fc95@dhcp-10-21-25-168>
In-Reply-To: <20180809121500.GP21639@ulmo>
References: <1533141150-10511-1-git-send-email-avienamo@nvidia.com>
        <1533141150-10511-3-git-send-email-avienamo@nvidia.com>
        <20180809121500.GP21639@ulmo>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.21.25.201]
X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To HQMAIL101.nvidia.com
 (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 9 Aug 2018 14:15:00 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:

> On Wed, Aug 01, 2018 at 07:31:52PM +0300, Aapo Vienamo wrote:
> > Document the pinctrl bindings used by the SDHCI driver to reconfigure
> > pad voltages on controllers supporting multiple voltage levels.
> > 
> > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> > Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/mmc/nvidia,tegra20-sdhci.txt          | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
> > index 9bce578..90c214d 100644
> > --- a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
> > +++ b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
> > @@ -38,3 +38,25 @@ sdhci@c8000200 {
> >  	power-gpios = <&gpio 155 0>; /* gpio PT3 */
> >  	bus-width = <8>;
> >  };
> > +
> > +Optional properties for Tegra210 and Tegra186:
> > +- pinctrl-names, pinctrl-0, pinctrl-1 : Specify pad voltage
> > +  configurations. Valid pinctrl-names are "sdmmc-3v3" and "sdmmc-1v8"
> > +  for controllers supporting multiple voltage levels. The order of names
> > +  should correspond to the pin configuration states in pinctrl-0 and
> > +  pinctrl-1.  
> 
> Do we also want "sdmmc-off" to allow SDMMC pads to be powered down when
> the slot or card is not used?

I don't see a real need for it, at least not in the context of this
series which aims to implement support for HS200 and UHS signaling. I
guess it could be added later if there's an actual case for it, where
turning off the pad would result in measureable change in total power
consumption.

 -Aapo

> > +
> > +Example:
> > +sdhci@700b0000 {
> > +	compatible = "nvidia,tegra210-sdhci", "nvidia,tegra124-sdhci";
> > +	reg = <0x0 0x700b0000 0x0 0x200>;
> > +	interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
> > +	clocks = <&tegra_car TEGRA210_CLK_SDMMC1>;
> > +	clock-names = "sdhci";
> > +	resets = <&tegra_car 14>;
> > +	reset-names = "sdhci";
> > +	pinctrl-names = "sdmmc-3v3", "sdmmc-1v8";
> > +	pinctrl-0 = <&sdmmc1_3v3>;
> > +	pinctrl-1 = <&sdmmc1_1v8>;
> > +	status = "disabled";
> > +};
> > -- 
> > 2.7.4
> >