Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Aug 2018 14:44:10 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc:     Sandipan Das <sandipan@linux.ibm.com>,
        aneesh.kumar@linux.vnet.ibm.com, jolsa@redhat.com,
        linux-kernel@vger.kernel.org, ravi.bangoria@linux.ibm.com
Subject: Re: [PATCH] perf probe powerpc: Fix trace event post-processing
Message-ID: <20180809174410.GD5395@kernel.org>
References: <20180809161929.35058-1-sandipan@linux.ibm.com>
 <1533831952.2wznw8gaoa.naveen@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1533831952.2wznw8gaoa.naveen@linux.ibm.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, Aug 09, 2018 at 09:56:24PM +0530, Naveen N. Rao escreveu:
> Sandipan Das wrote:
<SNIP>
> > This can be verified on a powerpc64le system as shown below.
<SNIP>
> > Before:
> >   # perf probe -v -a sys_open
<SNIP>
> >   # perf probe -v -a sys_open%return $retval
<SNIP>
> >   Failed to write event: Invalid argument
> >     Error: Failed to add events. Reason: Invalid argument (Code: -22)
> > After:
> >   # perf probe -v -a sys_open
<SNIP>
> >   Writing event: p:probe/sys_open _text+4276888
> >   Added new event:
> >     probe:sys_open       (on sys_open)
> >   ...
> > 
> >   # perf probe -v -a sys_open%return $retval
<SNIP>
> >   Writing event: r:probe/sys_open__return _text+4276888
> >   Added new event:
> >     probe:sys_open__return (on sys_open%return)
> > Fixes: 99e608b5954c ("perf probe ppc64le: Fix probe location when using DWARF")
> > Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> > Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
 
> Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>

Thanks, applied!

Excellent commit log message, btw, keep it up.

- arnaldo