Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2421562imm; Thu, 9 Aug 2018 12:37:00 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxVcmvyz1KRPujFyS7YSCQtiS0Yig4P9HIiKK6BnZUXAKddRL8tBKPXIKBqiBjvqmin4Vj6 X-Received: by 2002:a63:9b19:: with SMTP id r25-v6mr3410694pgd.44.1533843420092; Thu, 09 Aug 2018 12:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533843420; cv=none; d=google.com; s=arc-20160816; b=FnmF5NQaDWg8j5uIQmsebakjwL/A4KbAZYx4ZUaD5v/3RDF/CCQ5Hu9x1nfzVhFit4 iunW81vF8iuRsG1WqT5x5ewp0eo6DLqhC0mWe97weM+y1IY+HOsWIJBL5GZ3y7vVVs3a FCVjnHdMdeeQg5uP54iMuRdUDsO3TLDyPLHjEMtZ4ydOkeX9UqNd/sXLHmMEW4swH+30 ayAGFBKz8+Tqt4mpoaqLsg4laerwaIlJOECcp7z2xjLhrs68gYr2zaXEG0jYcE0XIG6I jq7PSRjtp9O7ucLpd6L+oWhPX9UUw/z6qwN/3VIpIvfW0fLJNJ3WVef2i6UVQAwFc8HZ qJ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=/daqkBlqoXro5YwGetc3s/IP28zktcplFkHtU3Hw0gw=; b=iGtYbsWb2FMCL+iOtfTCkSwikG5YYuNu3Nh68tSQc0s8cFmG3Ecn7jzl7+8f2OT8X5 nGPX/3otIILnjavNzQiS+ZYgzTU0fGl8MoF5q6IRyz6NPPMNuPVWKsojG2f5Q8/9TbUn wcF4e0pEfdM2Vta0VUol70rI+3mjDcwNJYIIYFntTAucHfBdn8hqARamWV98x44mEAC0 7wzraR8gFrDd6KP1oz5dKBvEpB8tHQxb1cw7tqOrXbcEiaiFBbeBBD/7B03tZ92L4QEZ fOWxgsM8i6GFMJ6OaaPhKp4cdoNTKaG9hywaSbwaAoYR1CC2Jpq3cPsDOGzfy8dbTsLm /nFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GHbpvuvf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4-v6si6942288pla.311.2018.08.09.12.36.45; Thu, 09 Aug 2018 12:37:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GHbpvuvf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbeHIWCM (ORCPT + 99 others); Thu, 9 Aug 2018 18:02:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbeHIWCL (ORCPT ); Thu, 9 Aug 2018 18:02:11 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 883792238D; Thu, 9 Aug 2018 19:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1533843354; bh=E3x1iniNupg8cgZkRSOgE6Kl27vf+vz4siI20PLsuRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHbpvuvfBIu3ZDOmPFC/Z7ieTg90TkjeOXVScS5k7koUvbrFE+7A5Ydn8ndZ7P76Y Wn7odw+PhMfBMS3ChzuSYFx2IlTYeHI8jsUy9hNf7lM2GHKpgpQxAI6G+E6TueSOpq tGsa8nmtvhTM3+BzOcD/fO9MgsPD17fHvKJlnwJ4= Date: Thu, 9 Aug 2018 14:35:53 -0500 From: Bjorn Helgaas To: Alex Williamson Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v3 3/3] PCI: Intel DC P3700 NVMe delay after FLR quirk Message-ID: <20180809193553.GD113140@bhelgaas-glaptop.roam.corp.google.com> References: <20180724160440.2729.75178.stgit@gimli.home> <20180724161446.2729.78211.stgit@gimli.home> <20180724101849.36f635eb@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180724101849.36f635eb@t450s.home> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 10:18:48AM -0600, Alex Williamson wrote: > On Tue, 24 Jul 2018 10:14:46 -0600 > Alex Williamson wrote: > > > Add a device specific reset for Intel DC P3700 NVMe device which > > exhibits a timeout failure in drivers waiting for the ready status to > > update after NVMe enable if the driver interacts with the device too > > quickly after FLR. As this has been observed in device assignment > > scenarios, resolve this with a device specific reset quirk to add an > > additional, heuristically determined, delay after the FLR completes. > > > > Signed-off-by: Alex Williamson > > --- > > drivers/pci/quirks.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > I forgot to link the bz in this one, if this somehow becomes the final > version, please add: > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=159265 Corrected link to: https://bugzilla.redhat.com/show_bug.cgi?id=1592654