Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2448217imm; Thu, 9 Aug 2018 13:07:52 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw7q+oFrBkCR9htn0zuMR6E8CR7Z3cs83JJBgRco2tcz/Au1w20qr/Jiz2pBovJi4JsN2Wn X-Received: by 2002:a17:902:1682:: with SMTP id h2-v6mr3296902plh.327.1533845272102; Thu, 09 Aug 2018 13:07:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533845272; cv=none; d=google.com; s=arc-20160816; b=t1wxrLl9vcAcAY+ohJZCNj7aO9l0/cDluaHEoZZBuvdUlIdEscQueex/xNVQ8r12XY uiy0zzHXHVN3nA+QF5f1RUg0NOYoWaehg8Z06KwUN/9C8mzwMJRNyhWlD9EqSuffGo86 Jud1sGbT/A+jjIJdOiogD7TMLyUVbfbAi2trmr+hp1cSMUB1z8pBUkpKjtCdi+qYyJc5 r9IXwGL1k2XGnZyjJRAwOCHgq4tw+Zz0Llft/LfO6udbpJ0jSho34m6fpDhXWIlGxxpF YvmV+HuzRoN061sAAVb+OpfSE50RPTmsHOeH6qmqP0jXu+b/RNloi8WD80H0P6DWMmaI gFqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=CjbzkaeX0Kf0ltc16i5dYk5x2p3gkJXBI7yFzHKXEkg=; b=c3QyBLCMLBzw95JsAJdNmlLne71lVsdycM+4VsG5PqVr0OvibuyvMEM7a0dVco0lyi SWTq9LbF9p/iezUhY5wGo3EeCxGINA/Aqs0wUT9ByKGkYcKzbbGq9hiQ3vjEemNE403N dT4OUrEkPI+C3ooqT3d5jsRZ4FC1mWYiwnBadASqN5Dp+5ipwRZBwTzpx7dOpTAJS3ae rNZOE71gAxe2Yr1igk/VOQphOzflwfMj/xI03enASUsFsglsLm52RErW+mbJ5XzMP5FI N0ol8k4DMZAja1cil8doAeA8cFvsmlWFfTwPHRyqseZGcx0UkeBtaadLOgSLDiLyZv/Z Qh2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 63-v6si8463125pfg.67.2018.08.09.13.07.37; Thu, 09 Aug 2018 13:07:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727225AbeHIWdI (ORCPT + 99 others); Thu, 9 Aug 2018 18:33:08 -0400 Received: from fieldses.org ([173.255.197.46]:49056 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbeHIWdI (ORCPT ); Thu, 9 Aug 2018 18:33:08 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 598E11E3A; Thu, 9 Aug 2018 16:06:44 -0400 (EDT) Date: Thu, 9 Aug 2018 16:06:44 -0400 From: "J. Bruce Fields" To: Anna Schumaker Cc: zhong jiang , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] net:svc_rdma_transport: remove unneeded variable 'ret' in rdma_listen_handler Message-ID: <20180809200644.GN23873@fieldses.org> References: <1533640809-1221-1-git-send-email-zhongjiang@huawei.com> <1533640809-1221-2-git-send-email-zhongjiang@huawei.com> <2c343d78-e668-1b97-a4e6-228296da0d70@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c343d78-e668-1b97-a4e6-228296da0d70@Netapp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 07, 2018 at 10:49:11AM -0400, Anna Schumaker wrote: > (Adding Bruce since he takes nfs / sunrpc server patches) Applied, thanks.--b. > > On 08/07/2018 07:20 AM, zhong jiang wrote: > > The ret is not modified after initalization, So just remove the variable > > and return 0. > > > > Signed-off-by: zhong jiang > > --- > > net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c > > index 547b2cd..2848caf 100644 > > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c > > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c > > @@ -296,7 +296,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > > struct rdma_cm_event *event) > > { > > struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr; > > - int ret = 0; > > > > trace_svcrdma_cm_event(event, sap); > > > > @@ -315,7 +314,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > > break; > > } > > > > - return ret; > > + return 0; > > } > > > > static int rdma_cma_handler(struct rdma_cm_id *cma_id, > >