Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2587426imm; Thu, 9 Aug 2018 16:06:35 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzaOLG7gmhy+KD9cjbVtXkKVcAHZgBKQOdPUg89Eccl73F0Gk4r22co8uvrILr2T3nOW4bD X-Received: by 2002:a63:4106:: with SMTP id o6-v6mr3962258pga.453.1533855995511; Thu, 09 Aug 2018 16:06:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533855995; cv=none; d=google.com; s=arc-20160816; b=uYDAT1VfCqGTF2bQoAkDNM3TKRvafg6EPOjzkLn3PnwVagmicsZ4HJZ6Hp5RWqcjpJ ANEFMoGiKtGcAER9Xvzqf+qqy5Cny9UZTDiPwpL0a4rNxekMM4nLMNNluNAvVrHDAesf mgK0Ba+LqNruMc+0oRo30fBSc8Wh9i20+voHqu+8yoI1xGK5/gEi1Ge5LX6tmqNSgOaj ilpBkKvdGUIaGDLT537Uc2hnxBisocJW2DsAtcudgfdQHS+XkRR5gtNxGnUu9I2Tu9ZR x7QG8+XnIoZSBO0uwVACGnUJWXCJ+Nn6qst3tccCmPQbug1s29QiHKjum8HFEhGxd+iV a+TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=oq186lwXwG0DFRsRGTM1et8pjKIHVGSRlQWgLe3U3XE=; b=rPtmTlclEUyfaL/XlXazYbko22HmVseg4XtgIMBPnAmQUni42uU7Rq/B+mqYBRhgWT VS9ar0SLOL/lg87yEIV+YKHeQAyzfuW9H31LY/VZD/b8h91qCQh4u/i/oiAUTPuEnTax PLQNh0WrEVQYEWFC5lVv264asLSBjImZAEZSN0AYH1YmdsluhIuX0bP2TrH+5aU2dcPy HXiZ2OuEen62/s0aiYcd537e1bkoHxteoE7cyn4piy2B0Njh2gdBX/fG8NPRryfwlk4p sTteEaSBSgWXW3VBc2Z/OPoTmQD3/YqMlyNn6HQH1qL6d48Pn6az4DGeNkICqoJqTURs N1oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9-v6si3880114plt.478.2018.08.09.16.05.51; Thu, 09 Aug 2018 16:06:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbeHJBaP (ORCPT + 99 others); Thu, 9 Aug 2018 21:30:15 -0400 Received: from mga03.intel.com ([134.134.136.65]:57362 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726882AbeHJBaP (ORCPT ); Thu, 9 Aug 2018 21:30:15 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 16:03:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="80454643" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.32]) by orsmga001.jf.intel.com with ESMTP; 09 Aug 2018 16:03:11 -0700 Date: Thu, 9 Aug 2018 16:03:11 -0700 From: "Raj, Ashok" To: Alex Williamson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Joerg Roedel , Bjorn Helgaas , Gage Eads , Ashok Raj Subject: Re: [PATCH] vfio/pci: Some buggy virtual functions incorrectly report 1 for intx. Message-ID: <20180809230311.GA79703@otc-nc-03> References: <1533843426-79170-1-git-send-email-ashok.raj@intel.com> <20180809134417.50de7fe7@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180809134417.50de7fe7@t450s.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 09, 2018 at 01:44:17PM -0600, Alex Williamson wrote: > On Thu, 9 Aug 2018 12:37:06 -0700 > Ashok Raj wrote: > > > PCI_INTERRUPT_PIN should always read 0 for SRIOV Virtual Functions. > > > > Some SRIOV devices have some bugs in RTL and VF's end up reading 1 > > instead of 0 for the PIN. > > Hi Ashok, > > One question, can we identify which VFs are known to have this issue so > that users (and downstreams) can know how to prioritize this patch? > Thanks, Hi Alex, The hardware isn't public yet, so can't talk about it :-(. Once this patch gets merged, will let the OSV engagement folks drive it for inclusions. We could mark this for stable, but i would rather wait until we know the timeline when they are expecting it to be in. It shouldn't break anything since we are just enforcing the spec. Cheers, Ashok