Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Julius Werner <jwerner@chromium.org>
From:   Stephen Boyd <swboyd@chromium.org>
In-Reply-To: <CAODwPW_ZiRMqUehq969UxiyrkNOfaevrE-G03M2z_C+6dNAxyQ@mail.gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Wei-Ning Huang <wnhuang@chromium.org>,
        Julius Werner <jwerner@chromium.org>,
        Brian Norris <briannorris@chromium.org>, samuel@sholland.org
References: <20180809171722.144325-1-swboyd@chromium.org>
 <20180809171722.144325-4-swboyd@chromium.org>
 <CAODwPW_ZiRMqUehq969UxiyrkNOfaevrE-G03M2z_C+6dNAxyQ@mail.gmail.com>
Message-ID: <153385745791.37448.8166542614146241338@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric
Date:   Thu, 09 Aug 2018 16:30:57 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Julius Werner (2018-08-09 11:10:42)
> > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void _=
_iomem *ptr)
> >                 ptr_entry +=3D entry.size;
> >         }
> >
> > -       if (ret)
> > +       if (ret) {
> > +               bus_unregister(&coreboot_bus_type);
> >                 iounmap(ptr);
> > +       }
> =

> nit: maybe cleaner to just do if (ret) coreboot_table_exit(); here?
> You're essentially writing the same code again.

Ok.