Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Julius Werner <jwerner@chromium.org>
From:   Stephen Boyd <swboyd@chromium.org>
In-Reply-To: <CAODwPW-Qc3JanqsB0C42O796fbDiwvUKYOhUXNYOaS_mzgCS8g@mail.gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Wei-Ning Huang <wnhuang@chromium.org>,
        Julius Werner <jwerner@chromium.org>,
        Brian Norris <briannorris@chromium.org>, samuel@sholland.org
References: <20180809171722.144325-1-swboyd@chromium.org>
 <20180809171722.144325-7-swboyd@chromium.org>
 <CAODwPW-Qc3JanqsB0C42O796fbDiwvUKYOhUXNYOaS_mzgCS8g@mail.gmail.com>
Message-ID: <153385821305.37448.14883992808536908679@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in
 coreboot_table_init()
Date:   Thu, 09 Aug 2018 16:43:33 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Julius Werner (2018-08-09 14:02:53)
> On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd <swboyd@chromium.org> wrote:
> > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct platform_d=
evice *pdev)
> >         if (!res->start || !len)
> >                 return -EINVAL;
> >
> > +       /* Map and check just the header first to make sure things are =
sane */
> >         header =3D memremap(res->start, sizeof(*header), MEMREMAP_WB);
> > -       if (header =3D=3D NULL)
> > +       if (!header)
> >                 return -ENOMEM;
> >
> > -       ptr =3D memremap(res->start, header->header_bytes + header->tab=
le_bytes,
> > -                      MEMREMAP_WB);
> > +       if (strncmp(header->signature, "LBIO", sizeof(header->signature=
))) {
> > +               dev_warn(dev, "coreboot table missing or corrupt!\n");
> > +               return -ENODEV;
> =

> Leaking the mapping here.

Thanks. Fixed.