Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2719612imm; Thu, 9 Aug 2018 19:16:23 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw0otiihvPVhsqFTvznKmfeElg2NyC6rkbCxUhiImX0YNzMfIzfLsAknUCWs/NDnzJTFVov X-Received: by 2002:a63:8dca:: with SMTP id z193-v6mr4461747pgd.228.1533867383799; Thu, 09 Aug 2018 19:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533867383; cv=none; d=google.com; s=arc-20160816; b=SvWIPpOeoCw1ZfqEQ89aMyaLQrwsnl/yv1vXqpTtKBq/Y1rt8+jz8nLgONQTDL18Li 7ovzrPv6Vp8jeTP/l8pA7wq6ov3yUVUtDz3EvTnTLSyTVJHfVRk88omnq4TE7zHcZuST uCiIZ/hbuNqz++CvhRtf4F7cwTcSgQW78K3TSiIcstswchPA8O+/wlpfTIb4bvUTD0s7 ZbJuqlArqiorGb/I2TF9rL1mZg8ZKyjk0muJ96KbvgMa13/cR4a7jYtRGYD8DepsP1sV CH81ib9UPMtvHxdCLMwKmUVSoSodwYMoPEBWXPMCYVCpGR3MxSAcXIqu04K55JeC2b83 qP9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=4g+E5NdjQX4HGRwIcIrlDzreG5ciJjqx4hAYwdO6j2o=; b=roZcOZrRfe6WlCqChA5/hgQNChFxAB1bfge/VI6KQ7ll7EPln62usb37Kkeycy+c4t M0/kEFuOUOc/0SDRMekMEZgv8fKu+UOXnetCT1rUk0IwM2XRglo7bqqObbccSsbIT4pf Rx8t2SntSDpI+SjFJNNTCyy26zfRLey1INWSezHHQj/J1RPStt2PErvATbXiviL/I8MC trTZdPe7/mHBXzq+4PVs1O1OERv3Zgs0GdxAC8cdFDMYCHZnJ7cV+B8VQ9SstFWREJ3Z E15gOhLqnL72pT+PyvCxLAkWZSv7+ZyQpB49qdswnV9C8ek2fsMRwt/0zE9LAnMTxYw6 yprA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LC5yhXa+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u24-v6si7920325pgk.72.2018.08.09.19.16.09; Thu, 09 Aug 2018 19:16:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LC5yhXa+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726975AbeHJEly (ORCPT + 99 others); Fri, 10 Aug 2018 00:41:54 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:36934 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725724AbeHJElx (ORCPT ); Fri, 10 Aug 2018 00:41:53 -0400 Received: by mail-ua1-f68.google.com with SMTP id y10-v6so367244uao.4; Thu, 09 Aug 2018 19:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4g+E5NdjQX4HGRwIcIrlDzreG5ciJjqx4hAYwdO6j2o=; b=LC5yhXa+J6Nastp6J7qXKQJl6/LTbshLsE6QCZW4MWXy3vwHGVEoZXY+m2f2Tn5r4j J9yZ+mxsE1bsTSAVzdxdUe9Iohk7LbVFQ/z02mCx9nOnly9vKgFcXMoK9tpaqmYNd6mZ fmiy3oyyPz9bb3++tUiknayHT73iJwabgomIdXFtaFaMtdJqHReLE/CTcOQoas2qaE/o ym0J7Bnd+rm1MzUJggdeyGy4xhFwHtJCWxeQpwltXfPModxwWHeGsr92Ups4fMYC8YtV vMFXgH7n3hAaNy+qtKSsjMmKlhZEwmn5SF7mBiHbyWeaH1jU6X4s2JN45r7wt5g9OQIr KHkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4g+E5NdjQX4HGRwIcIrlDzreG5ciJjqx4hAYwdO6j2o=; b=Bydfl6Ssbq/ST2XUHfUJ/mUu1iGQGAlqvhRCRzsdas8uievdxpEucjw3AEKMFXF1wP ymmimkoLSNYcOVV6pkDTNu/JYAki5BwS0FQQq8I1RIy6RhVr0cnXVjTfFr/B6V+zghIA 8vxhKXPwnwpZx4KR7XCuWphCRjM2JsotI5PtyFDUvM31PERD/RSPexpienSHWQT12+K2 wQFCSjvskoe89PMVSEKGG5YFcJ53JdPpcOXLzuFedQLU9OO7aw1P22gxbL44uMZNj/R9 +mnqAkPfSkDsBHnvQtiW4LVpuFme15W2h6PsMm0bFLFkHamnFIxUbM0ZaRi4YIjRZtRh OPkQ== X-Gm-Message-State: AOUpUlGgY/jG4N/dsUxSSx15Qz8XVrWF7/KINGaztASQnzXILUyr0X9h b6QvW1lg+STwzhMimtoKVmkBznhnND4oWcmHdMY= X-Received: by 2002:ab0:41e5:: with SMTP id 92-v6mr3159710uap.50.1533867253215; Thu, 09 Aug 2018 19:14:13 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:1927:0:0:0:0:0 with HTTP; Thu, 9 Aug 2018 19:14:12 -0700 (PDT) In-Reply-To: References: <1533659175-47076-1-git-send-email-gengdongjiu@huawei.com> From: Tyler Baicar Date: Thu, 9 Aug 2018 22:14:12 -0400 Message-ID: Subject: Re: [PATCH RESEND v2] arm64: clean the additional checks before calling ghes_notify_sea() To: gengdongjiu Cc: Dongjiu Geng , Borislav Petkov , Will Deacon , rafael.j.wysocki@intel.com, James Morse , Tyler Baicar , arm-mail-list , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, devel@acpica.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 9, 2018 at 6:16 PM, gengdongjiu wrote: > 2018-08-10 5:05 GMT+08:00 Tyler Baicar : >> On Thu, Aug 9, 2018 at 8:32 AM, gengdongjiu wrote: >>> >>> 2018-08-08 0:26 GMT+08:00 Dongjiu Geng : >>> > In order to remove the additional check before calling the >>> > ghes_notify_sea(), make stub definition when !CONFIG_ACPI_APEI_SEA. >>> > >>> > After this cleanup, we can simply call the ghes_notify_sea() to let >>> > APEI driver handle the SEA notification. >>> > >>> > CC: Tyler Baicar >>> > CC: James Morse >>> > Signed-off-by: Dongjiu Geng >>> > Acked-by: Will Deacon >>> > --- >>> > This cleanup is ever mentioned by Mark Rutland in [1] >>> > >>> > [1]: >>> > https://lkml.org/lkml/2018/5/31/289 >>> > >> >> FWIW - Looks good to me! > > Thanks very much for this comments and review, > whether I can get your "Acked-by" or "Reviewed-by"? thanks > Sorry, yes! Reviewed-by: Tyler Baicar