Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2761421imm; Thu, 9 Aug 2018 20:24:18 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzKlBKPn0BuX8OzzCR3l1PPxRHXTILn+2m5AUAqKqz5gV6aS0w22OXO5G/yF0hsDxc4MERb X-Received: by 2002:a17:902:7e06:: with SMTP id b6-v6mr4411360plm.230.1533871458079; Thu, 09 Aug 2018 20:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533871458; cv=none; d=google.com; s=arc-20160816; b=uustsaSr3cCRASjOCVFJybbjyrXPpu830uDVAm2gWpktbuNRxSoe+L0YjVAcOa305g AiHQG4bxSqvVtpBkkjLZLqkAayM/vTq8BoyjSw1+tOxDBjDAj3cA5R+feos4XfN+KN0l lueYu566pc+FdSmv2IKDVnRnNE3a8hcOGAbJE255+31urv8ZTGw2vCIdyTy6Vz27gsZN d077XCHdPsrYQBc4lqv9RNLNLRb3t/TgLeA+PYvU0ywY3CD2E893A4HmB1Q2MHbhfgNq CeuCaPvrPjj8DYXTCxi+alWhtTZX01bJl7qzHX+YA/BKtPeyctMeMX75GyqLRcSateB7 pkzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=E5saFQ9UFIyu/P1YgI81zjvtg7Ha4HLzdbKpBYtyyMY=; b=Na6AKsfpSSdCh6y1HCynTfBhAw84ivnawlYadxsTktX4itX8BEkPV06BUAIHjBvPkJ RkPc0Taaw/JvNIi8hz5mQFXN/v2Yb1/gv6kr10MzFToKYR6HF2EeCGOPVsRPMM/CfSE9 EMSURlSrSEyl4SN+W35iw5kLSqTe/Xo6dVwLkZYjbU5t7hP7qChP/wyiER3olh+ZcaoL Qtw6ZTMK6KPssEfqUaKVEaI60/aRXd7CFxvwPhu5nuTkPLp8DBQHROsmA01UcayOu6bF M3AUTawXHSRYmq2WV+j9RYnWnn1H2AQkmmyPIRH21k2RhtD+1+zqNSa7snyIf4/Yj/g2 xOJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iAkd8i3B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k14-v6si7497604pga.149.2018.08.09.20.23.40; Thu, 09 Aug 2018 20:24:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iAkd8i3B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727539AbeHJFtY (ORCPT + 99 others); Fri, 10 Aug 2018 01:49:24 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45524 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727526AbeHJFtY (ORCPT ); Fri, 10 Aug 2018 01:49:24 -0400 Received: by mail-pf1-f195.google.com with SMTP id i26-v6so3817251pfo.12 for ; Thu, 09 Aug 2018 20:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E5saFQ9UFIyu/P1YgI81zjvtg7Ha4HLzdbKpBYtyyMY=; b=iAkd8i3BU4DK7w53jkG9ENEGjBVibPKgVg7/MYkLoPlcIcsrz0+PW9yV5v1yDw/a6o fkQ6PiY33T3uB33yLxrNzRom8yhf8S1hEixJNkQtwJafOE/TE3dmu1Oiy1f49CO343y4 EnitGT5OpzC4yLjhuUQO+j6emu17tle/hfq4c7SfhAX928AtFNl5NnqmaxwT3SMl8Tdt 8+/0WVktPcyJ/eZhxOVVEhc7AMzp/VLKJ38FQ/7zLBfVd5KbBx/wRQR/dxnP7LjzvWF0 NZ2h9DEkrwpFBV2wXDN/YlKdVhCDbQYHfqPtMlYvMszLOa0UWIv2iM+qPIAWnUZhz6NM 9qLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E5saFQ9UFIyu/P1YgI81zjvtg7Ha4HLzdbKpBYtyyMY=; b=SIpn+yFOVXdZTd1IfnYeDPrpYYocS+t1PwYzP9n1KdQu+UgGAYbcbXdQ8/R/XDpbTS t/h2xIS3Od7t7d+QpCrlSiP+r6KHcYAPvXm7S8VX5L47eJr5IooCRDk2cnCFb+hTZ73f Q0bMJE4+pPgv6Z/v+j/0Ni6UH18fdW65aJ5DQJXINsdrPko7cUGyoK7bxjwy2hCZxywy bSzMxPcNjWJWojL0zI2KGtt5v1FDsbUvtOxu8xKZjxAvJI2pWLBk7SVtHEQ/3WpEk4aT 86AOka4q+eswL32l8bePHjJ6c8D7UPYYhPHS1W9wLKNFlBqBJ/+doR6Bd8NBSYKDRyKz 9MjQ== X-Gm-Message-State: AOUpUlF4tw9hXhkHo9l1E8dVcLwUQARIGxrit3msdolQUYocK4/nsspH FlY/Odzx8Hr4UUDa9ZSfmOc= X-Received: by 2002:a62:e218:: with SMTP id a24-v6mr5132790pfi.75.1533871291000; Thu, 09 Aug 2018 20:21:31 -0700 (PDT) Received: from toddpoynor2.mtv.corp.google.com ([2620:0:1000:3701:7d29:cd13:d903:7908]) by smtp.gmail.com with ESMTPSA id p73-v6sm16130871pfk.186.2018.08.09.20.21.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 20:21:30 -0700 (PDT) From: Todd Poynor To: Rob Springer , John Joseph , Ben Chan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Todd Poynor Subject: [PATCH 08/16] staging: gasket: page table: use dma_mapping_error for error detection Date: Thu, 9 Aug 2018 20:21:03 -0700 Message-Id: <20180810032111.197743-9-toddpoynor@gmail.com> X-Mailer: git-send-email 2.18.0.597.ga71716f1ad-goog In-Reply-To: <20180810032111.197743-1-toddpoynor@gmail.com> References: <20180810032111.197743-1-toddpoynor@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Todd Poynor gasket_perform_mapping() call dma_mapping_error() to determine if mapping failed. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c index bd921dc6094de..4d2499269499b 100644 --- a/drivers/staging/gasket/gasket_page_table.c +++ b/drivers/staging/gasket/gasket_page_table.c @@ -493,7 +493,8 @@ static int gasket_perform_mapping(struct gasket_page_table *pg_tbl, (void *)page_to_pfn(page), (unsigned long long)ptes[i].dma_addr); - if (ptes[i].dma_addr == -1) { + if (dma_mapping_error(pg_tbl->device, + ptes[i].dma_addr)) { dev_dbg(pg_tbl->device, "%s i %d -> fail to map page %llx " "[pfn %p ohys %p]\n", -- 2.18.0.597.ga71716f1ad-goog