Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2869163imm; Thu, 9 Aug 2018 23:04:40 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxbCkZognJWiyC3rIU9qgT/efLAKzc6V4187wmRcr7K+KE068zbbzAXjPN4zK2YuJs5Xl8o X-Received: by 2002:a17:902:e28b:: with SMTP id cf11-v6mr4902649plb.86.1533881080066; Thu, 09 Aug 2018 23:04:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533881080; cv=none; d=google.com; s=arc-20160816; b=RwgMlt8OWb2m4wKnyXfzjQTUIwGOgc62XaNFJbAealFF/nX6EERWof09JON5To+LQX 6LgugcFEVwUF5Uwt2/SZOfeBGC8OktueCyfuC9XLnpU0ZqYVQDOvOo9L9uyeAFlQnDVd yVnxRHWOBeaJ1J/AB6T/M1n1hDwVH4N5ep9tyG4TkT4SdJcZny636EUZPdWc8a9zP7lZ 9IRSipdymh08HKlPHbix677wI8wswTfxdKQ8tXyraV3auTaWPlr3QQ+73EVRkqoxoJNI +hR87ZjTsFO3msiiqu0CTM4wACZmfwSlQdEBTht8bSoAhVm/RlHOOMrC2iP/ASIXWg20 DosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=4mm7NDEFa98Beyggn8mgFx2+wuffWIlsvcSfFxip2E0=; b=Grciwo7VsjptsY0r6IABbV/rVenZrkddgYGt06Y7tG5SiHKUmYwgyfoaoXqmMwg7AT PeKOi2j0oAyb05VTDHbBqOEddF3caDyAfRqwrm4PZfz923vd0UkIk+hUTqq4/9ls5J5Y oNGVrB+Ntp5rNzNigGDPliek6XBNsvgr1L0RRfMfdrrAePlXf6UEEFXRCu24yqH7KKFt +tVQfQDWW8oMNQFo8bq61kBEzvQfZtbzMBgg8PZJOtnFm9l2pk/lDEZbcZ4xwKqHNBks dnnVPZS8yIvcYUAfzcR0/Rkxy01H8bMFOo7b7x7WXo3YEIbYI+7KaRbpdOsC6/3n2Wc5 RkBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 37-v6si8007053ple.169.2018.08.09.23.04.23; Thu, 09 Aug 2018 23:04:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727236AbeHJIbw (ORCPT + 99 others); Fri, 10 Aug 2018 04:31:52 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53730 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725746AbeHJIbw (ORCPT ); Fri, 10 Aug 2018 04:31:52 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 507577A7E9; Fri, 10 Aug 2018 06:03:31 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAF1B111AF2A; Fri, 10 Aug 2018 06:03:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id CC59211A9A; Fri, 10 Aug 2018 08:03:29 +0200 (CEST) Date: Fri, 10 Aug 2018 08:03:29 +0200 From: Gerd Hoffmann To: Anton Vasilyev Cc: Dave Airlie , David Airlie , virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] drm: qxl: Fix error handling at qxl_device_init Message-ID: <20180810060329.gipwvnw56v4gaela@sirius.home.kraxel.org> References: <20180727115440.11112-1-vasilyev@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180727115440.11112-1-vasilyev@ispras.ru> User-Agent: NeoMutt/20180622 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 10 Aug 2018 06:03:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 10 Aug 2018 06:03:31 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'kraxel@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2018 at 02:54:40PM +0300, Anton Vasilyev wrote: > If qxl_device_init fails on creating resources and does not report it, > then qxl module will catch null pointer exception on remove, or on > probe's error path. > > The patch adds error path with resources release into qxl_device_init. > > Found by Linux Driver Verification project (linuxtesting.org). Pushed to drm-misc-next. thanks, Gerd