Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2898906imm; Thu, 9 Aug 2018 23:44:10 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx6FnbFnRgowo6VdlezPdIyfgJhhXgWicdYCR5uhFJKR8c0Kz0RV6OebgpUs85CZMoL3CZX X-Received: by 2002:a17:902:33c2:: with SMTP id b60-v6mr4971283plc.11.1533883449995; Thu, 09 Aug 2018 23:44:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533883449; cv=none; d=google.com; s=arc-20160816; b=TQ0CfUhN/sqFu6EYWuTH68tGVOnehQUxWV1q5GV4GR0OUwhrpmpNL/uAwPECqyWLn8 h5vVYjWzMHm4FDXlPDXh+FlHxZLuTdmcyCQqKIDUkmU1QI04h/9+ugX+6ezBTIpykamf DJSxaVJgHxaz4S2FwRUIBOcaD5vZnFNr6myz16RnMAVLrby6w68TJGi0mgQANHESxTiA brnIHTAl8otvrYxoxL3ak+b0ynwLpg/Xh7k1wmKpTv8NWhYy1g845HScW0bf5ewfOR+8 gIEpvafPAhp0e2AXUwDeEEu5LfYSJh7AMuuQNo+m8AfHgLYTpMC70oSe05b2U8RpFU/5 5drw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:arc-authentication-results; bh=1tpUSv5R7amIbEQFEperoiNi0lSUSUKlV5SijwQXsAo=; b=YB8Ds39eeAKcMLTBC2+7YfhvkBGkV83b9jeSI2NoWHO1sXLrLTx4YJAYILv90MNjKM RnxyIe9iFnyh8L9SpVG+rpwVntKA5X6wA1+aWNqNHqbu1hk+/mjVmCj9pZqLGD+l4OzO JeR/OqASW+Hz1BUkqQAxNRurZQQ2+aReJc941Xgo505VZiBosGS4IF32l6Vb28dBr4yY U/2jqMFBYLGUwhl5rMRop3KydFNtCPWaQHvZpV2oUgz+4iwUxVqkf9WRYRRSUYyiAKZA 4/XrB4Y+leNqQm40GHswfNtHtct3jHYFLIK1xqbB6iB2CD3rqt+/AG+OzPdMnpoaz9Tb LRgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3-v6si7869522pln.298.2018.08.09.23.43.54; Thu, 09 Aug 2018 23:44:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727476AbeHJJLa (ORCPT + 99 others); Fri, 10 Aug 2018 05:11:30 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:58057 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727258AbeHJJLa (ORCPT ); Fri, 10 Aug 2018 05:11:30 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]) by mwinf5d02 with ME id MJiz1y00B3rYXCH03Jj0f0; Fri, 10 Aug 2018 08:43:00 +0200 X-ME-Helo: mail-qk0-f178.google.com X-ME-Auth: bWF4aS5qb3VyZGFuQHdhbmFkb28uZnI= X-ME-Date: Fri, 10 Aug 2018 08:43:00 +0200 X-ME-IP: 209.85.220.178 Received: by mail-qk0-f178.google.com with SMTP id c192-v6so5706446qkg.12; Thu, 09 Aug 2018 23:43:00 -0700 (PDT) X-Gm-Message-State: AOUpUlFvQAKmuOP5ihozwFQIH3f2cS9KHefiuZ3n5A4GWNz/LTSI+JAQ l46f1ZAy/vzbmE8EmPb9kFrB3wr9Wk5xbTyF43M= X-Received: by 2002:a37:b446:: with SMTP id d67-v6mr4760136qkf.104.1533883379178; Thu, 09 Aug 2018 23:42:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:278a:0:0:0:0:0 with HTTP; Thu, 9 Aug 2018 23:42:58 -0700 (PDT) In-Reply-To: References: <20180807220011.24436-1-maxi.jourdan@wanadoo.fr> <20180807220011.24436-4-maxi.jourdan@wanadoo.fr> <3221c65f87f8fd3541e0188186cb0259327cb671.camel@baylibre.com> From: Maxime Jourdan Date: Fri, 10 Aug 2018 08:42:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes. To: Neil Armstrong Cc: Jerome Brunet , Maxime Jourdan , Kevin Hilman , linux-amlogic , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-08-09 9:53 GMT+02:00 Neil Armstrong : > On 08/08/2018 10:41, Jerome Brunet wrote: >> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote: >>> Wrap the canvas node in a syscon node. >>> >>> Signed-off-by: Maxime Jourdan >>> --- >>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi >>> index b8dc4dbb391b..c98198662ae2 100644 >>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi >>> @@ -423,6 +423,23 @@ >>> }; >>> }; >>> >>> + dmcbus: bus@c8838000 { >>> + compatible = "simple-bus"; >>> + reg = <0x0 0xc8838000 0x0 0x1000>; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges = <0x0 0x0 0x0 0xc8838000 0x0 0x1000>; >>> + >>> + sysctrl_DMC: system-controller@0 { >>> + compatible = "amlogic,gx-dmc-sysctrl", "syscon", "simple-mfd"; >>> + reg = <0x0 0x0 0x0 0x1000>; >>> + >>> + canvas: canvas-provider@0 { >>> + compatible = "amlogic,canvas"; >> >> If there is only one canvas provider under "sysctrl_DMC" and it has no reg >> property , you should not put a unit-address (@0) here. (same for the >> documentation patch) >> >> You may have seen unit-address without a reg property used elsewhere (ASoC >> simple-card, my recent axg-sound-card), when there is multiple node with the >> same node-name (ex: dai-link). Ack. >> As Martin pointed out, the DT spec says we should not use unit-address unless >> there is a reg property. We did not get Rob's view on this and we might have to >> update this later on. In your case, unless I missed something, you should >> definitely not have it >> >> nitpick regarding the node-name (canvas-provider). If appropriate, we should try >> to stick to one of the generic names proposed in the spec. I wonder if the >> canvas provider could be viewed as a "memory" or "memory-controller" > > It's not really a memory or memory-controller, it's a Lookup Table on top of the memory controller, > nothing really matches here... Thanks for the comments. It will be "video-lut" as suggested. >> >> So, what about this ? Just a proposition, feel free to comment ;) >> >> sysctrl_DMC: system-controller@0 { compatib >> le = "amlogic,gx-dmc-sysctrl", "syscon", "simple-mfd";> reg = >> <0x0 0x0 0x0 0x1000>; >> >> canvas: memory-controller { >> compatible = "amlogic,canvas"; >> } >> >> [...] >> >> >>> + }; >>> + }; >>> + }; >>> + >>> hiubus: bus@c883c000 { >>> compatible = "simple-bus"; >>> reg = <0x0 0xc883c000 0x0 0x2000>; >> >> >