Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2967352imm; Fri, 10 Aug 2018 01:12:27 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxHfA/ZKh/1+texKvp8SKbCHPRFVbfPj57n9e2V+PeBMOmNlupFCRHuBBVqV0zO2lycSlpn X-Received: by 2002:a17:902:bc8b:: with SMTP id bb11-v6mr5150401plb.112.1533888747406; Fri, 10 Aug 2018 01:12:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533888747; cv=none; d=google.com; s=arc-20160816; b=ArlxOs/Cko9BNaFQQIWhax3sBkAnxc0tiGJQAEBMfP3ehVK8LbPpVCI+NhhMsHpfs1 +Ddqj1D+svzq34MCV/kbpT6puCv6lH8bGPjbcO2kgbn7GLFhsq5E9PrwnBE55kOC1KQE Qw82pNrZDv8CbWGjnBqidXPknsAuPYhpu8Nh+j4c75nIfGIJ+tFFQVMlfoDTqAWw8R3w OrtEPdMvWEnRLGm6mZbLymdEXVs8o8Vfdq4vNgCbxBBB5hncw0DNnsF8uaJkTkznZfIH JGDPH/V3J72MGITWjZV9Lywdi/1haYKaain92l2nFwRZ9NiV/uYOyVWhCijnZ682YwhK K08g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=ZtOSkkpLyY5oymSlHooxe8Vnv7GsO+riwpQ/wHD/2F8=; b=rDakJT8EE75slGaE34t9RyFRYYSc3MLG++jGM6KA+z4xj8eicohdaTXfXzHsFf3GLA iZbJ07o3tPMWacT0pwoHqWUtxiCcB3YGdY0jzN4S/cdmto7Ke0ToOoKStsKFoqReweNv bjN0X6MVk39MPq1QgxoMHVm+XaEXhD8dWTo65nHUnByvS/WTLID04/cDqfo9/ujwZw/d 1XMnyKZ7vb2J1sk6aBdq8dJrrnyaNqoSuj7VqftJ3mspzjLCWSt5AKtwiwoL9PmY1IiP 6TaUC6eGdUO0xn9ISwJ/341zC7m0N50m40QdEh5iKcePiFsCw7JpM1/9j0j5pIehbFkh /iiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LUDf24kn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f16-v6si10379483pfd.276.2018.08.10.01.12.12; Fri, 10 Aug 2018 01:12:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LUDf24kn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbeHJKjQ (ORCPT + 99 others); Fri, 10 Aug 2018 06:39:16 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:51631 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727225AbeHJKjQ (ORCPT ); Fri, 10 Aug 2018 06:39:16 -0400 Received: by mail-wm0-f67.google.com with SMTP id y2-v6so949286wma.1 for ; Fri, 10 Aug 2018 01:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZtOSkkpLyY5oymSlHooxe8Vnv7GsO+riwpQ/wHD/2F8=; b=LUDf24knO+1vWyA2ur2S5lYNdL9KlsK7wn4v3RDHEbBps4SCcAk+A0mnrux5pobdIV p6vcyNS8de125CmAX3sCJ5JGymjEpmpja6DonFIAUVUikHc/7dsn6JDcg3L7hF6abcbU I0QxegJJENMeBAb/xyDxuvK7icoLZz7b14qw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZtOSkkpLyY5oymSlHooxe8Vnv7GsO+riwpQ/wHD/2F8=; b=ZFJze9C/MVOxWEabr9D1ceklfFoafDfrGsLNAQAysLpZPBIgsLAYWXVdmbjVw+u9/q d2uX9vkEmeuhM0d5/utLDiJ8v2MwtStAA/I/rY2ct4tDRWwaa7DUYhPXUfUSDVsee3G1 XdFH2KCRXSrfOJ3qprP31+UtnH92hmKXIvYB5rhdw/uRWRNpAO0mMWvIpylB2OOX/gRT RwAzUCRGbRnnBCSN/j9nlpwYuYVawE/YbZzIzxoblJsAf5PRKlmAJGdbTIsrzlK6D9yI H0IF2o+bcFGyVlpVvOqjlSw4iAG3yJxk9BBQ2dWeLuY0sqy1ug0TEiSF1pTMRIriV2t9 2tDg== X-Gm-Message-State: AOUpUlEwUkBN5UWma0UERHzgUhyyVhZlU+m4SwvK4JjRq3/V0j2NgavQ XmIi18/RwUcwSd5F2+j252w2Ig== X-Received: by 2002:a1c:8a04:: with SMTP id m4-v6mr765489wmd.137.1533888628593; Fri, 10 Aug 2018 01:10:28 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id s2-v6sm7940515wrn.83.2018.08.10.01.10.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 01:10:28 -0700 (PDT) Subject: Re: [PATCH v2 04/29] nvmem: provide nvmem_dev_name() To: Bartosz Golaszewski , Jonathan Corbet , Sekhar Nori , Kevin Hilman , Russell King , Arnd Bergmann , Greg Kroah-Hartman , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Grygorii Strashko , "David S . Miller" , Naren , Mauro Carvalho Chehab , Andrew Morton , Lukas Wunner , Dan Carpenter , Florian Fainelli , Ivan Khoronzhuk , Sven Van Asbroeck , Paolo Abeni , Alban Bedel , Rob Herring , David Lechner , Andrew Lunn Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski References: <20180810080526.27207-1-brgl@bgdev.pl> <20180810080526.27207-5-brgl@bgdev.pl> From: Srinivas Kandagatla Message-ID: <45fda8c0-aa09-3c4b-69ee-9a61265f1120@linaro.org> Date: Fri, 10 Aug 2018 09:10:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180810080526.27207-5-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/18 09:05, Bartosz Golaszewski wrote: > > +const char *nvmem_dev_name(struct nvmem_device *nvmem) > +{ > + return dev_name(&nvmem->dev); > +} > +EXPORT_SYMBOL_GPL(nvmem_dev_name); > + Kernel doc for this is missing! Other than that it looks good to me! --srini