Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-Id: <5B6D7FB402000078001DCF30@prv1-mh.provo.novell.com>
Date:   Fri, 10 Aug 2018 06:06:12 -0600
From:   "Jan Beulich" <JBeulich@suse.com>
To:     "Juergen Gross" <jgross@suse.com>
Cc:     "the arch/x86 maintainers" <x86@kernel.org>, <tglx@linutronix.de>,
        "Linux Virtualization" <virtualization@lists.linux-foundation.org>,
        "xen-devel" <xen-devel@lists.xenproject.org>,
        "Boris Ostrovsky" <boris.ostrovsky@oracle.com>, <mingo@redhat.com>,
        <rusty@rustcorp.com.au>, <linux-kernel@vger.kernel.org>,
        "Alok Kataria" <akataria@vmware.com>, <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH 04/10] x86/paravirt: use a single ops
 structure
References: <20180810115252.18213-1-jgross@suse.com>
 <20180810115252.18213-5-jgross@suse.com>
In-Reply-To: <20180810115252.18213-5-jgross@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>>> On 10.08.18 at 13:52, <jgross@suse.com> wrote:
> --- a/arch/x86/hyperv/mmu.c
> +++ b/arch/x86/hyperv/mmu.c
> @@ -228,9 +228,9 @@ void hyperv_setup_mmu_ops(void)
>  
>  	if (!(ms_hyperv.hints & HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED)) {
>  		pr_info("Using hypercall for remote TLB flush\n");
> -		pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
> +		pv_ops.pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;

Taking just this as example, why not

		pv_ops.mmu.flush_tlb_others = hyperv_flush_tlb_others;

? Both pv_ and _ops are redundant on the field names.

Jan