Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp181933imm; Fri, 10 Aug 2018 09:30:32 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzbVtRHSUT/qrJvzh+s+/YXWG/wwBwzzECYZ/rYsU0ds3BAlXVU7Qh2+tt1BY8TKFadlaVx X-Received: by 2002:a17:902:7088:: with SMTP id z8-v6mr6669104plk.303.1533918632623; Fri, 10 Aug 2018 09:30:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533918632; cv=none; d=google.com; s=arc-20160816; b=Caoi2Hkm6Rpuz8wAwe6HCRYnMyGnNq41JPdVaqPHIp3zlUTsXpAA8etIJHgY46GUpV CoDh88h9em66WegJ9yLY9/u8w3K22S01Nz1zG8mTGtNP5Jt7KMv9xg2XmwYAc6MPNU45 CvVJqRXLUnp7cdx0/x/OiPqPpuWgFHg6fzmf820Zo6l9//sgi153bi15T7Z7Fv9cNjqP ELd9t6TcD5PIvJZOUUHGUKsGjoLKPi1PrhDm3Wiz4vh+on0uLe8gWOY6cw/RmQA7UFV9 ky8Ig1E4kmJwrsULsaujzEx50lx0exMbJmLV4sG1jWuB9J0Mg5Ni+K/rNoW+v2JoYKcP hSyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=yTkDr33tScXwB77cW6QGhr3sB9hkG+WH2/p7aanIwPI=; b=dsnbYnYzwQDMaP4eNlXjlYeBKio4yrizyOmpCcVuhqVmehgDJW821fjZQzBy4MJlMC izgHQ6RD6fp67cZCRGKSfJ2oHp0Ovy+aHT9OeDMGa1JCjv3vZSzR/qAelUSbC1dK03Bq LvfcrbztWVOIjCqYfQYXhDntQkneYth27MIykMA1BDiSrNjeJL6ryVMonQ9bfXiZw0bs JRTDxop8UaQWBjreyOmDsZaspZ6HNFcEbmNEvuI8aVGystWllsUGOaWq+E5VYLB5Bja7 0kUt/ivyBJoRszpRI/+pTqhWPVU17GvNZIF4m+NlEtl8Bry3hGyHWyRLYeOzt4ATRQKm cNwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lR8kzG+f; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6-v6si9126403pgn.416.2018.08.10.09.30.17; Fri, 10 Aug 2018 09:30:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lR8kzG+f; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729208AbeHJTAA (ORCPT + 99 others); Fri, 10 Aug 2018 15:00:00 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43062 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727795AbeHJTAA (ORCPT ); Fri, 10 Aug 2018 15:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yTkDr33tScXwB77cW6QGhr3sB9hkG+WH2/p7aanIwPI=; b=lR8kzG+fLl1d1rbo/FBesAUHR gInqfmfJ1EA6ZedWx9gE0zu6rFtfTAOXjTfjJMM4oE+Yb0fBxJFmQbmY7eA3sfkqAmFU+Jcwu/uF7 D7JYFV9LBbzsyLDPFisU0NLA+sWRdZxdD2tQZkxNFKJovuF12j8EApDJxgrGJoPhJxdSU=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1foAHw-0004ru-Pk; Fri, 10 Aug 2018 16:29:20 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 70ACA112435F; Fri, 10 Aug 2018 17:29:20 +0100 (BST) Date: Fri, 10 Aug 2018 17:29:20 +0100 From: Mark Brown To: David Collins Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org, sboyd@kernel.org, dianders@chromium.org, mka@chromium.org Subject: Re: [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180810162920.GG20971@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f5QefDQHtn8hx44O" Content-Disposition: inline In-Reply-To: X-Cookie: Words are the voice of the heart. User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f5QefDQHtn8hx44O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 13, 2018 at 06:50:59PM -0700, David Collins wrote: > + switch (rpmh_mode) { > + default: > + mode = REGULATOR_MODE_INVALID; > + } I'm not sure why the break statements are being omitted in default cases, but I do find myself stopping and trying to figure it out? --f5QefDQHtn8hx44O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlttvV8ACgkQJNaLcl1U h9AVEAf+PwJei1gP+kqd4Alr2LPAKXL4NorS7ssYny2+0zOCpf8eby40kxVR5SqL bN5VjqG2U1KnEjE4Ff1ROxIZYsiWTjzfpU0wMO/waNdnLYpz3CE0Hp/CpZ/qJx5A Oigh6G1M4olEbQEddYU2aPRxIHhn3tdwpgBVkcGml53oq28adakeDeF9Pnxa/eVY bFc8HZuSq87W3JJVCByyB81qrntgBM//Mnhzm0G0vA3xNtFq1QktAv6kt9X2vb5c QYH0mWUNsfv1d+ETohJ1HALsrsxUVUbWMThFQ6n3i/GjLiCePyfDI7jqAXpdn/yl cjyoDf4ctT6qfPb0eRv88rkX0RDIcg== =1kxy -----END PGP SIGNATURE----- --f5QefDQHtn8hx44O--