Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180810032111.197743-1-toddpoynor@gmail.com> <20180810032111.197743-3-toddpoynor@gmail.com>
 <CALTjKEM2q=pGh+nz6O7mQerkcnZ+=B6t+viu7dwfMHjZMQRXGg@mail.gmail.com>
In-Reply-To: <CALTjKEM2q=pGh+nz6O7mQerkcnZ+=B6t+viu7dwfMHjZMQRXGg@mail.gmail.com>
From:   Rob Springer <rspringer@google.com>
Date:   Fri, 10 Aug 2018 09:57:30 -0700
Message-ID: <CALTjKEN=jwaasgdb_GMd7i1mPowS16MKxUoBbpHV++RSCu0dfw@mail.gmail.com>
Subject: Re: [PATCH 02/16] staging: gasket: core: remove debug log that could crash
To:     toddpoynor@gmail.com
Cc:     John Joseph <jnjoseph@google.com>, benchan@chromium.org,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, Todd Poynor <toddpoynor@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Rob Springer <rspringer@google.com>

On Fri, Aug 10, 2018 at 9:56 AM Rob Springer <rspringer@google.com> wrote:
>
> Revewed-by: Rob Springer <rspringer@google.com>
>
> On Thu, Aug 9, 2018 at 8:21 PM Todd Poynor <toddpoynor@gmail.com> wrote:
>>
>> From: Todd Poynor <toddpoynor@google.com>
>>
>> A debug log in gasket_alloc_dev() is issued regardless of whether the
>> device pointer used returned success or error.  The log isn't that
>> useful anyway, remove it.
>>
>> Signed-off-by: Todd Poynor <toddpoynor@google.com>
>> ---
>>  drivers/staging/gasket/gasket_core.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
>> index d12ab560411f7..37d14e30ffa21 100644
>> --- a/drivers/staging/gasket/gasket_core.c
>> +++ b/drivers/staging/gasket/gasket_core.c
>> @@ -234,8 +234,6 @@ static int gasket_alloc_dev(struct gasket_internal_desc *internal_desc,
>>         dev_info->device = device_create(internal_desc->class, parent,
>>                 dev_info->devt, gasket_dev, dev_info->name);
>>
>> -       dev_dbg(dev_info->device, "Gasket device allocated.\n");
>> -
>>         /* cdev has not yet been added; cdev_added is 0 */
>>         dev_info->gasket_dev_ptr = gasket_dev;
>>         /* ownership is all 0, indicating no owner or opens. */
>> --
>> 2.18.0.597.ga71716f1ad-goog
>>