Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 Aug 2018 10:07:09 -0700
From:   "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC][PATCH] tracepoints: Free early tracepoints after RCU is
 initialized
Reply-To: paulmck@linux.vnet.ibm.com
References: <20180810123042.51ceddb9@gandalf.local.home>
 <20180810123517.5e9714ad@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180810123517.5e9714ad@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-Id: <20180810170709.GW24813@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 10, 2018 at 12:35:17PM -0400, Steven Rostedt wrote:
> On Fri, 10 Aug 2018 12:30:42 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> Maybe I should say SRCU?

That would be an improvement.  What, me read comments?  ;-)

						Thanx, Paul

> +/* SRCU is initialized at core_initcall */
> +postcore_initcall(release_early_probes);
> +
>  static inline void release_probes(struct tracepoint_func *old)
>  {
>  	if (old) {
>  		struct tp_probes *tp_probes = container_of(old,
>  			struct tp_probes, probes[0]);
> +
> +		/*
> +		 * We can't free probes if SRCU is not initialized yet.
> +		 * Postpone the freeing till after SRCU is initialized.
> +		 */
> +		if (unlikely(!ok_to_free_tracepoints)) {
> +			tp_probes->rcu.next = early_probes;
> +			early_probes = &tp_probes->rcu;
> +			return;
> +		}
> +
> 
> -- Steve
>