Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp439409imm;
        Fri, 10 Aug 2018 14:15:00 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPwBBVmJUmmUzL5Le1nWzD8J+VuJYG4VPeT9lGxzewKllXkxHdFusxN5A4M38pKXC8s23MdA
X-Received: by 2002:a62:669b:: with SMTP id s27-v6mr8768841pfj.224.1533935700733;
        Fri, 10 Aug 2018 14:15:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1533935700; cv=none;
        d=google.com; s=arc-20160816;
        b=S8o3vKjzBVqAWILLTrrwGPttQHtv+2RhxG3tRu2hT1wVYo7THaZgd/2KkQfAZ0FtiV
         ykBzLBQkzOWQOEPKCUTl6w5Bgtg8f1A9/+tY53bmJlrS8U+ewmpwd7tD5+XyX0EMflDu
         S1bR+C9/zVaUBZF4PTEnz3W90D34Mt0q1s0W/KTusFjQ2Qux8hO62KLok8rGhEKsBe6n
         8Qt+gYuZoqjJsc9RDyJggJwZHGBmCmqSTB2zYf5ghiqSTVLz54OCcH+j0/sY3FU8zLru
         TVFpWjSv5tqRJrukzlaKYJpK8SRUKyhRt+57O7QHIiXThDLYApTZqcSTFVKMh+6N1xbN
         Xi3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature
         :arc-authentication-results;
        bh=khmANU8iDhx4r8vxpuS8hQodT9G7h2LbOa34r6pb+eM=;
        b=x8lv83NJcqLprw4K7Loz64h2k5QvPhyAX5Qb88z9RPrjwouLVE52V7YyMwD0wTWBiI
         4GnAJpOSNRc6NHkGaTz4U5yS1YHs6sEOcP0DHW/9dUunJ/oB6kGQxEkTJi6JZH9qugrC
         N1dblLTgsKYyWEgwOPo7PaktEtKp5JhhyJuAsLuV7CwkhgNBETJNZBG8ae6wbVaQKon8
         I5zdJdqaVGcLkBhv+b1PeG8OMtemKLbXSo9EnKfVsZlwqhLN7XgCR9si7/Te3+fYmgsx
         2D3RUhQL6dVKqcypmOhFkqAyuZQtNh1fi+gwXetUxWVaygG+FvmF3qNtSWTxSRPPCBax
         KflA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=EOCfvh0h;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z24-v6si6764393plo.5.2018.08.10.14.14.45;
        Fri, 10 Aug 2018 14:15:00 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=EOCfvh0h;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727347AbeHJXpQ (ORCPT <rfc822;stevepeted@gmail.com>
        + 99 others); Fri, 10 Aug 2018 19:45:16 -0400
Received: from mail-io0-f195.google.com ([209.85.223.195]:34273 "EHLO
        mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727239AbeHJXpQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Aug 2018 19:45:16 -0400
Received: by mail-io0-f195.google.com with SMTP id l7-v6so8879796ioj.1
        for <linux-kernel@vger.kernel.org>; Fri, 10 Aug 2018 14:13:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=khmANU8iDhx4r8vxpuS8hQodT9G7h2LbOa34r6pb+eM=;
        b=EOCfvh0hN+eLoJDFIxwRXOK46dG5Be978UTS+cozwISs2ilUmKly+ufP6iYbNzcK5V
         G7gHV1MwYk3uD5Yzq4B6cigWiudMe5wqm4xmQrZtJVxyGimuQmrU340NtxGbuNGbZgqr
         IBXPrLetcmpEDY/ItaU2i7HrSmi30Of/D7EYo=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=khmANU8iDhx4r8vxpuS8hQodT9G7h2LbOa34r6pb+eM=;
        b=dKxe2KiTke2lbtYbq4UMZyJNqtK/wixs1C3RfHWMz9H+okZO/SXH4jkdlaWI3+33g9
         1iP8TFXLfINZKwZ8Jt2G/pZibN89gss0WkmBNez3LFRVzHqnyFDYw4zn7DSu/UXxOOHd
         RDkT14Ayq4LQNgkUSWk81uridrxERa9SGPdGTxuy9IUsmS3NljKN4r8I9eFmbq4jyaYT
         bxEJjT+fcKyF/vAK+TyuYY+3j40e8UxyITtioekYQDKBkd9yDNEEYqIw6JAR0BaW3GuN
         XXye0LbNuuQYNfuo01z3D1jIIVlvSPSPOns6oBKDDOA/Xnyiq9oUHKA23KuZ2wGBuDSM
         CT6g==
X-Gm-Message-State: AOUpUlGcGCiQM8qew23+wkudlwfZ3h2JvCMZFKkAbkMLM98zzNBwaX4W
        kwGIOUWx0YykXwsgYJ2ouD0uxp9Bae44dSZV1poZv+6S
X-Received: by 2002:a6b:6306:: with SMTP id p6-v6mr6888501iog.175.1533935623355;
 Fri, 10 Aug 2018 14:13:43 -0700 (PDT)
MIME-Version: 1.0
References: <20180806160635.9293-1-vasilyev@ispras.ru>
In-Reply-To: <20180806160635.9293-1-vasilyev@ispras.ru>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 10 Aug 2018 23:13:31 +0200
Message-ID: <CACRpkdY1wtMN_bq+za=nhd_xYb-23g2zeA++ouwxVsJMxH5L9Q@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: axp209: Fix NULL pointer dereference after allocation
To:     vasilyev@ispras.ru
Cc:     Chen-Yu Tsai <wens@csie.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ldv-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 6, 2018 at 6:07 PM Anton Vasilyev <vasilyev@ispras.ru> wrote:

> There is no check that allocation in axp20x_funcs_groups_from_mask
> is successful.
> The patch adds corresponding check and return values.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>

Patch applied with Chen-Yu's ACK.

Yours,
Linus Walleij