Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp636599imm; Fri, 10 Aug 2018 19:13:06 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzOmOClbM0cgo9sNnX7eKH4NMUF7O+Vlwzt+TNXxCF4AHvxT0AggLT7W2trEl0LAQwsLU++ X-Received: by 2002:a63:1262:: with SMTP id 34-v6mr8808615pgs.154.1533953586395; Fri, 10 Aug 2018 19:13:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533953586; cv=none; d=google.com; s=arc-20160816; b=TILa+BXhqPDD304aKeqLQOZexw30iJ3+AsVyrhf4swsfZl0t57epSz2iAtbKgkP+/e YCQY0jABxgjZGpllgJyozslcWFMGrQ1tX7XlgzAuucD1obGMa01ouSTCsF9AJo5SVMdE X6IeEKKSeBd8tJzjzmnjjKj+U+x9F9+B52HWGhF2WHLBUHbPivv2+QG9+Y0yY6Bv7bRz a8WGGPeyiNrjqXfgtyFR0qyYMTKfB9qT+R7aILWBY3/YtK/0OAoN9g8mYmsWx+32pR8F /DbdqAXrlwzl1kLYwlNc/DMqSi/j0SjyLKcN/Id54v5xSVKBkohmUIh0Q10dphUh7sUA TrvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Tx4CR/BNe57jlikmhm1sVBlN9QeeHx62R2vEPuEooFY=; b=NpYp4Kvt//RzNwq4iO8CANpfFnwFOUrc9fldvqBnqbQpx8Bop4PrCxwtQhtzqOmRim irMWA7h6JRNVUgV5z0vS6JXSL8XMRrAgqt/+A5twIQRDaOnICZSzyXBulN3GDfL7bp2k ErA91eZRrRxyG6ccwJB2z5puEhBKHC40etsDNJjUsKXhCkHdQzP7LNEqcNUfNiLB0kgi TiTvvfSbFFk7COdT5gBrm4mdfRJ4s17YqA0lJ5EADe6NTKE7ia4K5yiP1xet53S/mJxI qyEbneJsdK4Cd2h9Vqy2OVccskN6WIp+XN+Z20Td/F/z5QYMXzr2ldHj8uMyyzyOIlsK OsUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18-v6si11916915pfi.88.2018.08.10.19.12.49; Fri, 10 Aug 2018 19:13:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727242AbeHKEoU (ORCPT + 99 others); Sat, 11 Aug 2018 00:44:20 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33178 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeHKEoU (ORCPT ); Sat, 11 Aug 2018 00:44:20 -0400 Received: from localhost (unknown [172.58.35.185]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3E5681434C5F9; Fri, 10 Aug 2018 19:11:54 -0700 (PDT) Date: Fri, 10 Aug 2018 19:11:53 -0700 (PDT) Message-Id: <20180810.191153.2290770424551316173.davem@davemloft.net> To: andrew@lunn.ch Cc: Jisheng.Zhang@synaptics.com, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: mvneta: fix mvneta_config_rss on armada 3700 From: David Miller In-Reply-To: <20180810222335.GD11955@lunn.ch> References: <20180810113627.5dec5d40@xhacker.debian> <20180810.144031.861564620036768413.davem@davemloft.net> <20180810222335.GD11955@lunn.ch> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Aug 2018 19:11:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Sat, 11 Aug 2018 00:23:35 +0200 > On Fri, Aug 10, 2018 at 02:40:31PM -0700, David Miller wrote: >> From: Jisheng Zhang >> Date: Fri, 10 Aug 2018 11:36:27 +0800 >> >> > The mvneta Ethernet driver is used on a few different Marvell SoCs. >> > Some SoCs have per cpu interrupts for Ethernet events, the driver uses >> > a per CPU napi structure for this case. Some SoCs such as armada 3700 >> > have a single interrupt for Ethernet events, the driver uses a global >> > napi structure for this case. >> > >> > Current mvneta_config_rss() always operates the per cpu napi structure. >> > Fix it by operating a global napi for "single interrupt" case, and per >> > cpu napi structure for remaining cases. >> > >> > Signed-off-by: Jisheng Zhang >> > Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC") >> >> Applied, thanks. > > Hi David > > Please can you queue up: > > Fixes: 7a86f05faf11 ("net: ethernet: mvneta: Fix napi structure mixup on armada 3700") > > and this patch for stable. If you want things to go to -stable, don't mark them for net-next as this patch was. If it isn't appropriate for 'net' it isn't appropriate for -stable either.