Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp837863imm; Sat, 11 Aug 2018 00:31:43 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzPOc44+6jluoZjnh5R37bidQJQawdPRi7ilyGTGq6fMT8ydslsSSDZuP5hlElNz7C+iuUo X-Received: by 2002:a63:5758:: with SMTP id h24-v6mr9291591pgm.432.1533972703901; Sat, 11 Aug 2018 00:31:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533972703; cv=none; d=google.com; s=arc-20160816; b=m1T00EbB1Pc7gAPFPQmVnzGLHz9+g3drCBMNgYeM5ylZHpfkr5vkq2gPBrAFzlCCkI t/IjvFzfdqscpKqXR8B9QgdHbykdrm08GHnGoMPadbsLIuc6Vb+mjQkl2apWtuOAkOFm yDrj9R2VD2nPFbsu11lRd+1NVAgfaUhrop+1g9UfeGvyMuC3SmgLrC9aQRVCwkgckfVS lRL05GnvX9Ie9NY8WRUXJ2PV0PpEZcP3kf1kPZRYMnT49wHvhTk6IB5Cr45Xn4vZICM+ b8x9OTr8XNXMXM8wDl9Yqye2JYRI5VmXmS+vBKAA/G2+/kpVsQhCHkG+uMDjGIB0kANd qsoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=Ly8glUfiMmO0ztLwA/1KAHMydGE+xBuOA4GHnnxMEeE=; b=oliNOkxrMlPf+RcWFlkFpMbjG0+0l+sdaNaUVGuj1GtJGFd69tfKFeeEGRmO8Hh8+8 vnOoG7f6Z/nhKioHiuDzoznXVqTtf7hmozgCrkL9Ajqx0ZGZKreWGEoqzkg1OY85WdVD oRYIPbtvGZXSmKr5JoHBNNkJ7P3VstUb6f8ReeHawroeg157gUZn/A6/9AD8IuPjo42y BMyIOsV4OgC11UXBtdWhJ8YppzAY/S05H3rwWTGtWuBb2W9Z0InLbFGX+Oz67MppKqau 4uOX+gtbJM2hfPCHTsyGnxqx3eVIShj2NIGc/oYbVtA5sdb9+NcG3XitzjoRP9QTTzEr +T1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p67-v6si11085202pfg.295.2018.08.11.00.31.16; Sat, 11 Aug 2018 00:31:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727197AbeHKKDJ (ORCPT + 99 others); Sat, 11 Aug 2018 06:03:09 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41438 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727088AbeHKKDJ (ORCPT ); Sat, 11 Aug 2018 06:03:09 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C3CAF2B50; Sat, 11 Aug 2018 07:29:52 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-78.rdu2.redhat.com [10.10.120.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 433A810075E6; Sat, 11 Aug 2018 07:29:47 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87pnyphf8i.fsf@xmission.com> References: <87pnyphf8i.fsf@xmission.com> <87d0uqpba5.fsf@xmission.com> <153313703562.13253.5766498657900728120.stgit@warthog.procyon.org.uk> <22361.1533913891@warthog.procyon.org.uk> To: ebiederm@xmission.com (Eric W. Biederman) Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, John Johansen , Tejun Heo , selinux@tycho.nsa.gov, Paul Moore , Li Zefan , linux-api@vger.kernel.org, apparmor@lists.ubuntu.com, Casey Schaufler , fenghua.yu@intel.com, Greg Kroah-Hartman , Eric Biggers , linux-security-module@vger.kernel.org, Tetsuo Handa , Johannes Weiner , Stephen Smalley , tomoyo-dev-en@lists.sourceforge.jp, cgroups@vger.kernel.org, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Theodore Y. Ts'o" , Miklos Szeredi Subject: Re: BUG: Mount ignores mount options MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <30364.1533972586.1@warthog.procyon.org.uk> Date: Sat, 11 Aug 2018 08:29:46 +0100 Message-ID: <30365.1533972586@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sat, 11 Aug 2018 07:29:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sat, 11 Aug 2018 07:29:52 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > > Yes, I agree it would be nice to have, but it *doesn't* really need > > supporting right this minute, since what I have now oughtn't to break the > > current behaviour. > > I am really reluctant to endorse anything that propagates the issues of > the current interface in the new mount interface. Do realise that your problem cannot be solved through fsopen() until every filesystem is converted to the new fs_context-based sget() since the flag has to make it from the VFS through the filesystem to sget(). I'm reluctant to add this flag till that point until that time unless we error out if the flag is set against a legacy filesystem. David