Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Problems with uio_pci_generic in v4.18-rc8
To:     "Harris, James R" <james.r.harris@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Walker, Benjamin" <benjamin.walker@intel.com>,
        "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
References: <21BF98B1-0EA5-46BC-BC68-196190880087@intel.com>
From:   Xiubo Li <xiubli@redhat.com>
Message-ID: <7ac09d84-31bf-4d25-dba7-0a61effa2b04@redhat.com>
Date:   Sun, 12 Aug 2018 18:55:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <21BF98B1-0EA5-46BC-BC68-196190880087@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Harris,

Since the lock protection in uio irq handler is useless currently as 
discussed in the mail list, so I will revert this commit with small 
changes and now the testing based LIO/TCMU has been finished.

Thanks,
BRs


On 2018/8/11 5:12, Harris, James R wrote:
> Hi,
>   
> Using Linux kernel v4.18-rc8, I am unable to bind a PCI device to uio_pci_generic.  This works fine with v4.18-rc4.  dmesg shows:
>   
> [  336.221585] genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 33
> [  336.221681] uio_pci_generic: probe of 0000:04:00.0 failed with error -22
>   
> This problem has been reproduced on multiple systems.
>   
> This seems to be related to commit 9421e45f5 (“uio: use request_threaded_irq instead”) which was merged in -rc5.  Reverting this commit fixes the issue (I also reverted 543af5861f and 57c5f4df0a which also touch uio.c - just to be safe).
>   
> This seems like a serious regression to uio_pci_generic, but any tips or pointers would be appreciated.
>   
> Thanks,
>   
> Jim Harris
>