Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Rafael J. Wysocki" <rjw@rjwysocki.net>
To:     Aaron Ma <aaron.ma@canonical.com>
Cc:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI / EC: Use ec_no_wakeup on ThinkPad X1 Yoga 3rd
Date:   Sun, 12 Aug 2018 13:14:46 +0200
Message-ID: <1855499.yJd7R0ESNr@aspire.rjw.lan>
In-Reply-To: <20180731105239.22008-1-aaron.ma@canonical.com>
References: <20180731105239.22008-1-aaron.ma@canonical.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tuesday, July 31, 2018 12:52:39 PM CEST Aaron Ma wrote:
> Like on X1C6, on X1Y3 EC interrupts constantly wake up system from
> s2idle, the power consumption is extremely high.
> So make ec_no_wakeup be true as default to keep system in s2idle mode
> and reduce power consumption.
> 
> Power button works when ec_no_wakeup=true.
> 
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
>  drivers/acpi/ec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 917f77f4cb55..6291d5c77267 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -2045,6 +2045,13 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
>  			DMI_MATCH(DMI_PRODUCT_FAMILY, "Thinkpad X1 Carbon 6th"),
>  		},
>  	},
> +	{
> +		.ident = "ThinkPad X1 Yoga 3rd",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Yoga 3rd"),
> +		},
> +	},
>  	{ },
>  };
>  
> 

Applied, thanks!