Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2650218imm; Sun, 12 Aug 2018 20:19:00 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx3SmftesEvEC9Vzwib2KIxpu/iU0fcNBDN3zDtDDpZNeNR0WUosrdDmuq1fW7dOUfmeR3I X-Received: by 2002:a17:902:7b96:: with SMTP id w22-v6mr14967955pll.24.1534130340603; Sun, 12 Aug 2018 20:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534130340; cv=none; d=google.com; s=arc-20160816; b=U2UfM9kEU2vJXtSz/OFK3BHBiP7fGvKeVB5JX1dyB4GxPzDs3PTNNR5bZU+TyDcBvx K/ABt17tWSAZNWxuz7Z4iiHwJ38+a0JMCkCFBPqoHaNPv6vSH9D0u27y54lzRPMSyh0l Knsn/9o4e5IUmJFI68WpEI0gt/6X78iUutdk4SOO/4yUg8JBcn77Jx9ajLmBJTTidPBg TDiSvkcSdKpp2gCByTE2yDKWSsSBp5zuZg/cZIPdNu/BzWBQezc5uo35e9318UDDZLVD 4ptV3rrVbbAZ4CfYuV2w1QwHdrNP4J+l54z3klI10+aIaAt3w4tY83DVHnFVyAMOQXiC fcmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=6t5q2T9/gZW7IC/HqthQzfC5PM9dOPsHqh7faD7GUSU=; b=x55X/R3HBIbWOe/5ihBUdoZm9h5Vrga0TDPVyDKTGhcCnhPYu7lVnkjgwr1XFue7fJ FeuUb+HYEQvggs+SnubNmTINOZgVtZiitfutnMdqxrRahDm8tT5wR65SvVV/e5SCGjfH A7v7jQIMEqE27su1tjFCp40QwOgijAuVVc0BJldOyxea0fh4l4Ls0ERRUrQ19piZ9pVm TQtWG2ahTaWvD2Bg6c0lVu+7zt60xnrTCkT9ro6JRQ+wBrN4T+6orSQYAUkq10haGOBp RLVdlw46QbywJ2pJsjAUpkc1S8zPsKi32Zpu+A1a6GHKK19XmM/AUrJrsw7Jp2me8i9j +vrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1-v6si18289901pgx.60.2018.08.12.20.18.42; Sun, 12 Aug 2018 20:19:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728163AbeHMF5z (ORCPT + 99 others); Mon, 13 Aug 2018 01:57:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728055AbeHMF5y (ORCPT ); Mon, 13 Aug 2018 01:57:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B11CF8780F; Mon, 13 Aug 2018 03:17:39 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (ovpn-12-183.pek2.redhat.com [10.72.12.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id B36872156712; Mon, 13 Aug 2018 03:17:36 +0000 (UTC) From: Jason Wang To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, jbrouer@redhat.com, mst@redhat.com, Jason Wang Subject: [RFC PATCH net-next V2 1/6] net: core: factor out generic XDP check and process routine Date: Mon, 13 Aug 2018 11:17:25 +0800 Message-Id: <1534130250-5302-2-git-send-email-jasowang@redhat.com> In-Reply-To: <1534130250-5302-1-git-send-email-jasowang@redhat.com> References: <1534130250-5302-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 13 Aug 2018 03:17:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 13 Aug 2018 03:17:39 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jasowang@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Jason Wang --- net/core/dev.c | 35 ++++++++++++++++++++++------------- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index f68122f..605c66e 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4392,13 +4392,9 @@ int do_xdp_generic(struct bpf_prog *xdp_prog, struct sk_buff *skb) } EXPORT_SYMBOL_GPL(do_xdp_generic); -static int netif_rx_internal(struct sk_buff *skb) +static int netif_do_generic_xdp(struct sk_buff *skb) { - int ret; - - net_timestamp_check(netdev_tstamp_prequeue, skb); - - trace_netif_rx(skb); + int ret = XDP_PASS; if (static_branch_unlikely(&generic_xdp_needed_key)) { int ret; @@ -4408,15 +4404,28 @@ static int netif_rx_internal(struct sk_buff *skb) ret = do_xdp_generic(rcu_dereference(skb->dev->xdp_prog), skb); rcu_read_unlock(); preempt_enable(); - - /* Consider XDP consuming the packet a success from - * the netdev point of view we do not want to count - * this as an error. - */ - if (ret != XDP_PASS) - return NET_RX_SUCCESS; } + return ret; +} + +static int netif_rx_internal(struct sk_buff *skb) +{ + int ret; + + net_timestamp_check(netdev_tstamp_prequeue, skb); + + trace_netif_rx(skb); + + ret = netif_do_generic_xdp(skb); + + /* Consider XDP consuming the packet a success from + * the netdev point of view we do not want to count + * this as an error. + */ + if (ret != XDP_PASS) + return NET_RX_SUCCESS; + #ifdef CONFIG_RPS if (static_key_false(&rps_needed)) { struct rps_dev_flow voidflow, *rflow = &voidflow; -- 2.7.4