Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2650448imm; Sun, 12 Aug 2018 20:19:17 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyo84hZ346tR1osuRDJ92cLqSGJWe8rXPb3+J/rayDIYrP8382Snr+dY8KumsnsL7MY1AgA X-Received: by 2002:a17:902:28a4:: with SMTP id f33-v6mr14945242plb.297.1534130357779; Sun, 12 Aug 2018 20:19:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534130357; cv=none; d=google.com; s=arc-20160816; b=P6G0fQ4Z/tHOb81kuzJAKdgsuj97Vbeuc0Y84WRdkEnz4DcyW7edsbqVX8MHxTJid5 ne7Flk6GefWWf8iCuAfxpRPixkoLMycT1r1QxwaYTYhkq2AZmj1/eQ2aJTSxNJGPMhE5 WN75u5LKz0Dxl92C3XDWBfWYarIS+lg/tAk1d29Djj5OBJHiM0XFNhAP6YqRBRcn3aeK WHl9InFSKPetPv+wFF8XEV0yjZOfM4q1siazro+xM5mfRTu9zHfKvwvgbAMKQDPnUUSE hQv0nuoLaGzzm9NCyN2o6Q21loXd6V3wFPDaEH0i8c+8rg4aNOfv/0eX9r8mqY12yFqw 1wyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=LNamXZnGi1qCNrjVpnemFnbq9Y+hg4mIjW1ygn8t1x4=; b=tSGwgQOt20+0U3IxPWslb0iIJQffCNhepRwgK8HQID+Hv8HqnNcXNPhDGQxKkmkk7m wchWbhDnSTHknzlDh5CwWVF3sfGT4Oyj7KVRGhM0EsHo9/lINctiCThYJVh15a2sLb9p uuA4Py6x3cg79VC+mt2hTfzKLEd+ECZ14F0xhXKGKSASjy2osbEdLLyWBijz1zVRQR3A qFXwAw9CZcnJvI1DBVRsadgfjEY0lJOnzh9Cz4bBPurQxAVYeUIWRSQ1Ytn1WFvg9ETl zZn1HbqVmauaFmQc75SoBuzhiRLId2sT5ZXfTspjE59j0jCuhj4eM98nsjgp9MX+0CRj bdfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d26-v6si16152886pgb.571.2018.08.12.20.19.02; Sun, 12 Aug 2018 20:19:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728436AbeHMF6P (ORCPT + 99 others); Mon, 13 Aug 2018 01:58:15 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33320 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727798AbeHMF6O (ORCPT ); Mon, 13 Aug 2018 01:58:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFAAE401B3BC; Mon, 13 Aug 2018 03:17:58 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (ovpn-12-183.pek2.redhat.com [10.72.12.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id D51992156712; Mon, 13 Aug 2018 03:17:55 +0000 (UTC) From: Jason Wang To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, jbrouer@redhat.com, mst@redhat.com, Jason Wang Subject: [RFC PATCH net-next V2 6/6] virtio-net: support XDP rx handler Date: Mon, 13 Aug 2018 11:17:30 +0800 Message-Id: <1534130250-5302-7-git-send-email-jasowang@redhat.com> In-Reply-To: <1534130250-5302-1-git-send-email-jasowang@redhat.com> References: <1534130250-5302-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 13 Aug 2018 03:17:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 13 Aug 2018 03:17:58 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jasowang@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch tries to add the support of XDP rx handler to virtio-net. This is straight-forward, just call xdp_do_pass() and behave depends on its return value. Test was done by using XDP_DROP (xdp1) for macvlan on top of virtio-net. PPS of SKB mode was ~1.2Mpps while PPS of native XDP mode was ~2.2Mpps. About 83% improvement was measured. Notes: for RFC, only mergeable buffer case was implemented. Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 62311dd..1e22ad9 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -777,6 +777,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, rcu_read_lock(); xdp_prog = rcu_dereference(rq->xdp_prog); if (xdp_prog) { + rx_xdp_handler_result_t ret; struct xdp_frame *xdpf; struct page *xdp_page; struct xdp_buff xdp; @@ -825,6 +826,15 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, switch (act) { case XDP_PASS: + ret = xdp_do_pass(&xdp); + if (ret == RX_XDP_HANDLER_DROP) + goto drop; + if (ret != RX_XDP_HANDLER_FALLBACK) { + if (unlikely(xdp_page != page)) + put_page(page); + rcu_read_unlock(); + goto xdp_xmit; + } /* recalculate offset to account for any header * adjustments. Note other cases do not build an * skb and avoid using offset @@ -881,6 +891,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, case XDP_ABORTED: trace_xdp_exception(vi->dev, xdp_prog, act); /* fall through */ +drop: case XDP_DROP: if (unlikely(xdp_page != page)) __free_pages(xdp_page, 0); -- 2.7.4