Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Aug 2018 08:34:55 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Tom Todd <thomas.m.a.todd@gmail.com>
Cc:     joe@perches.com, stern@rowland.harvard.edu,
        dan.carpenter@oracle.com, arvind.yadav.cs@gmail.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] USB: core: devio: Restructured proc_ioctl for
 readability
Message-ID: <20180813063455.GA29496@kroah.com>
References: <10f9f13a5421299a6efda1e1f84ab304ef18ddec.camel@perches.com>
 <20180812222653.3341-1-thomas.m.a.todd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180812222653.3341-1-thomas.m.a.todd@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Aug 12, 2018 at 11:26:54PM +0100, Tom Todd wrote:
> On, Sun, 12 Aug 2018 11:34:59 -0700 Joe Perches wrote:
> >On Sun, 2018-08-12 at 19:06 +0100, Tom Todd wrote:
> >> Fixed a code styling issue
> >while it's OK to fix style only issues, it's much better
> >to reorganize the code for reader clarity.
> 
> Ok, thank you, I've taken your suggestions and created the a new version
> 
> Restructured method proc_ioctl for readability and fixed code style
> errors.

Please always be very specific as to exactly what code style issues you
are fixing.  And never do more than one type of fix at a time, otherwise
it is hard to review, and you can cause errors to be added, like you did
here :(

Please do not start working on code cleanups in any other area of the
kernel other than drivers/staging/ as that is what that is for.  To do
so in other areas of the kernel causes more work for maintainers.

thanks,

greg k-h