Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180811094853.32167-1-stefan@agner.ch>
References: <20180811094853.32167-1-stefan@agner.ch>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Mon, 13 Aug 2018 16:38:17 +0900
Message-ID: <CAK7LNAQ2THEDLB8so3zahGykH_BWaWAU7Tg_2yGEPKo+ApsxHg@mail.gmail.com>
Subject: Re: [PATCH] gcc-plugins: require GCC
To:     Stefan Agner <stefan@agner.ch>, Kees Cook <keescook@chromium.org>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, jbacik@fb.com,
        Emese Revfy <re.emese@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-08-11 18:48 GMT+09:00 Stefan Agner <stefan@agner.ch>:
> Unsurprisingly GCC plugins require GCC as a compiler. This avoids
> GCC plugins being selectable when using clang.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 1aa59063f1fd..8c693a837ed7 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -422,7 +422,7 @@ config HAVE_GCC_PLUGINS
>
>  menuconfig GCC_PLUGINS
>         bool "GCC plugins"
> -       depends on HAVE_GCC_PLUGINS
> +       depends on HAVE_GCC_PLUGINS && CC_IS_GCC
>         depends on PLUGIN_HOSTCC != ""
>         help
>           GCC plugins are loadable modules that provide extra features to the
> --
> 2.18.0
>

I guess the more correct way is to fix
scripts/gcc-plugin.sh

This shell script should exit 0
only when GCC plugin is supported.

Kees?


-- 
Best Regards
Masahiro Yamada