Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Heiko Stuebner <heiko@sntech.de>
To:     Tao Huang <huangtao@rock-chips.com>
Cc:     Caesar Wang <wxt@rock-chips.com>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org,
        Brian Norris <briannorris@chromium.org>,
        Xing Zheng <zhengxing@rock-chips.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        dbasehore@chromium.org, Will Deacon <will.deacon@arm.com>,
        dianders@chromium.org, Rob Herring <robh+dt@kernel.org>,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        tony.xie@rock-chips.com, David Wu <david.wu@rock-chips.com>,
        cf@rock-chips.com, Jianqun Xu <jay.xu@rock-chips.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add idle-states to device tree for rk3399
Date:   Mon, 13 Aug 2018 10:25:41 +0200
Message-ID: <3578407.YVa0lydFsh@phil>
In-Reply-To: <ae312dc3-f640-ecf3-049a-c8576bb83330@rock-chips.com>
References: <1467793254-10808-1-git-send-email-wxt@rock-chips.com> <5620784.b19SH5PkdR@phil> <ae312dc3-f640-ecf3-049a-c8576bb83330@rock-chips.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tao,

Am Sonntag, 12. August 2018, 18:24:45 CEST schrieb Tao Huang:
> On 2018年08月10日 04:09, Heiko Stuebner wrote:
> > Am Mittwoch, 6. Juli 2016, 10:20:54 CEST schrieb Caesar Wang:
> >
> >>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 18 ++++++++++++++++++
> >>  1 file changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> index a6dd623..12ce265 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> @@ -101,6 +101,18 @@
> >>  			};
> >>  		};
> >>  
> >> +		idle-states {
> >> +			entry-method = "psci";
> >> +			cpu_sleep: cpu-sleep-0 {
> >> +				compatible = "arm,idle-state";
> >> +				local-timer-stop;
> >> +				arm,psci-suspend-param = <0x0010000>;
> >> +				entry-latency-us = <350>;
> >> +				exit-latency-us = <600>;
> >> +				min-residency-us = <1150>;
> > Looking at the chromeos kernel, there are some more patches adapting
> > this idle-state to use different timings.
> Yes, we have another values. So the values of this patch are wrong.
> >
> > There also was a cluster-idle state added for a while but that seems to
> > cause audio issues according to the CrOS history.
> 
> DMA or Audio driver should add PM_QOS_CPU_DMA_LATENCY or other methods to avoid the effects of idle.
> Idle itself is good.

Thanks for the clarification. Do you know if some from Rockchip plans
on submitting a new version of the patch with changed timings and
cluster-sleep?

Otherwise I can also just pull the values from the vendor kernel so that
we get idle states in mainline as well.


Thanks
Heiko