Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2942428imm; Mon, 13 Aug 2018 03:18:33 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx+j7QQ9T60jB5zL0QRTXEX1Kbm4vmi5P6q5bGq1GnlFBiT2sPG8UH4MYMwBvISsW+g/v9D X-Received: by 2002:a17:902:6e16:: with SMTP id u22-v6mr15664394plk.13.1534155512951; Mon, 13 Aug 2018 03:18:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534155512; cv=none; d=google.com; s=arc-20160816; b=m/rt4/oq4tsJObNFlcq7NVav5CUVFkIUjoiKy3C3Eko2EZzUwN83x7dgIFnYEJv3nr JCRpUX/LSTBmqYzDsqKN5jtEz3qwcNUq+wmcTdzA34aG/qeNzz4M/nqDC3UVDgBuLIPg oeQY1TA0Ju7dkzD+z1BaWBRGNTDpSS8KnKqLNpoyLwtPFVFilV84yAqEsW81f32lceLC umDvhOFx9QPpN81d15BFff0ImR71poRly4ZsYQgDUzlbDOjJelcPZpHrnXgblYUMtXDw qa3H40TxWm11vT/yOAMCRhOlWbQ7lJtURTUYhA+UMvzLqgWEsL61RDPCUnDCA4CnPOP7 fF6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qqjkb9i6c+XjbClTvLKReUlr72MzKh8bM+1FboQm/VQ=; b=vJYzhi0ZDrKwyT6RPlKHBJbXzdFnTzwCg54CqKO/YjECBrwXXalB+wkxHaORZxW93a uEJ4dhn2lQ1tOgQZ8c/TsW9hyNe7cAck54aEDlYom1WChNMCWiET+kMqm8AYyXmzMEXw iB1SRW1jHiSVXbGnpMDS8uqbgBxvnuVDZCCqTuQzbXkEjetaUgwHm7aCEaiYKiJPz76S EitdPXa1J7zBTozJU6PvKhxJxj62lS/BBo3e9wYFtgjaMXFt6wPFXCivc+ZBKHNVmjDg vx1pCInNAHwZa2Q5jgNu0VMwg6LdktPiTZwFrmp6A8goKinL3gy7ZamyiobPWYg7T2L2 Fwrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r138-v6si18860814pfc.202.2018.08.13.03.18.16; Mon, 13 Aug 2018 03:18:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728578AbeHMM7G (ORCPT + 99 others); Mon, 13 Aug 2018 08:59:06 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:56530 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728240AbeHMM7G (ORCPT ); Mon, 13 Aug 2018 08:59:06 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD52E7A9; Mon, 13 Aug 2018 03:17:29 -0700 (PDT) Received: from e110439-lin (e110439-lin.Emea.Arm.com [10.4.12.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DEF8E3F5D0; Mon, 13 Aug 2018 03:17:26 -0700 (PDT) Date: Mon, 13 Aug 2018 11:17:24 +0100 From: Patrick Bellasi To: Quentin Perret Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v3 06/14] sched/cpufreq: uclamp: add utilization clamping for RT tasks Message-ID: <20180813101724.GB2605@e110439-lin> References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-7-patrick.bellasi@arm.com> <20180807135403.s7jktvxmhycujeht@queper01-lin> <20180809154156.gdsx2vacjmp6p6dp@darkstar> <20180809155551.bp46sixk4u3ilcnh@queper01-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180809155551.bp46sixk4u3ilcnh@queper01-lin> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Quentin! On 09-Aug 16:55, Quentin Perret wrote: > Hi Patrick, > > On Thursday 09 Aug 2018 at 16:41:56 (+0100), Patrick Bellasi wrote: > > > IIUC, not far below this you should still have something like: > > > > > > if (rt_rq_is_runnable(&rq->rt)) > > > return max; > > > > Do you mean that when RT tasks are RUNNABLE we still want to got to > > MAX? Not sure to understand... since this patch is actually to clamp > > the RT class... > > Argh, reading my message again it wasn't very clear indeed. Sorry about > that ... > > What I'm try to say is that your patch does _not_ remove the snippet of code > above from sugov_get_util(). So I think that when a RT task is runnable, > you will not reach the end of the function where the clamping is done. > And this is not what you want AFAICT. > > Does that make any sense ? Oh gotcha... you right, I've missed that bit when I rebased on tip. Will fix on the next iteration! -- #include Patrick Bellasi