Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3001131imm; Mon, 13 Aug 2018 04:25:16 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzMf4AtaCW9TVt7ExcF88S4rdXtmZ4XvnQ08+wdv46NmJfvo1H8nfnDsFQcehc4ArYVQr+C X-Received: by 2002:a62:d1b:: with SMTP id v27-v6mr18822424pfi.87.1534159516678; Mon, 13 Aug 2018 04:25:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534159516; cv=none; d=google.com; s=arc-20160816; b=khFEtw3pek1vs8VKhqlohV45Dd3nMaGSsM4OpLCM/TxuV1uOwb3SOHY+hynmDwHkvL ihw60IDfBk+LWHE9l/qMXn/748oN3r9mdM41U1AdRVnlNbCEDT/5eOgKEHxs3Dh2XiQu Al9JrlF752bLfOF91Zimsx1SGS8c3ETbeJIXi5adhCJHSJTx+ZAKtRFs/j3ThmUVdNRe ZHM4y0nTYFR1McGRM3z/2oGXveBT6xrpsN8GQ48d2d5P7CFXvU2noBRmdW0M/t2Kn5HH 7Yb9CNIjwaaBehoi8ExVdk0/xKl5UjisUx++wcyKxO9WVrBJxr/q53a8/tUrhOylFZBY 9Xyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=FqOWyOnofP/gynvqe/K4XC3/0n2I4Iw1BOcevtzWEJE=; b=DB4asOpujZrAjdGoqHp73W9Xbrf1yJhpUgVuvIYi9PPT2Kbah9xxb58oKGWj9JFsYy gA6gNwiC8rjzw90es8Px84cPfodEE1Ufert777nru1zp+MMSnUe7eJ0XAjkkBkeD95CW SNUtNPKtjMGgo5yQqKJDvg01WPofpWj0FRydLGDWr9FgwZS/IeiABcO4pKd0V6ek/xIP B8cEoC2vqdFXJ3CzeR49mgdVcEBb+hF9qnfdHfnqDL87JXJzw6wxriZeFuO2Vh1FAy+E epdHQonFKxpwLmArRhR32WaXZU0akYkcQprXZbnTJVN7bvWmkVDybNHU+bqA4P4mt9mI 67Ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p15-v6si15848506pll.42.2018.08.13.04.25.02; Mon, 13 Aug 2018 04:25:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729796AbeHMOFr (ORCPT + 99 others); Mon, 13 Aug 2018 10:05:47 -0400 Received: from ozlabs.org ([203.11.71.1]:51935 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729461AbeHMOEy (ORCPT ); Mon, 13 Aug 2018 10:04:54 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 41ptd34Q5zz9sC7; Mon, 13 Aug 2018 21:23:03 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 550ddadcc7580ec2a6c22d4ed04291bc6e2428fb In-Reply-To: <20180430145558.4308-14-npiggin@gmail.com> To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, Nicholas Piggin , Greg Kroah-Hartman Subject: Re: [13/15] tty: hvc: hvc_write may sleep Message-Id: <41ptd34Q5zz9sC7@ozlabs.org> Date: Mon, 13 Aug 2018 21:23:03 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-04-30 at 14:55:56 UTC, Nicholas Piggin wrote: > Rework the hvc_write loop to drop and re-take the spinlock on each > iteration, add a cond_resched. Don't bother with an initial hvc_push > initially, which makes the logic simpler -- just do a hvc_push on > each time around the loop. > > Signed-off-by: Nicholas Piggin Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/550ddadcc7580ec2a6c22d4ed04291 cheers