Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3207877imm; Mon, 13 Aug 2018 07:48:05 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxymR549jYh5dv5jHgigcPT2jxs82S1yrrdNteJRckdXNM4YjYyRw3Lvl4s+sa2wNZkL4NU X-Received: by 2002:a62:5dd7:: with SMTP id n84-v6mr19387215pfj.68.1534171685182; Mon, 13 Aug 2018 07:48:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534171685; cv=none; d=google.com; s=arc-20160816; b=f4EKs+hK0WrZqknL9RYlMsfuL2lmtEnj43EdCgNCKR5fdJLeOFrXEAzIYWp/4g5qN8 G00/sbWRguhdW0tJOv3VujAxLavYqiTEIYvICV5I+FNZ6zK4jf0skuU9VwOcJZ6oj2fF DYOvNGFW6BS61aIw8EVK2kL24NYwARwpqoKIsqkg1r8PqMyLWKnCdleBxUmKdIG9HLIc 6/aOAKem560TRAhI95Cz2QXUtZE5KQiU6GpA17jE8fLDSE9dapghf4erjlaFoxFyn8uL +AjXzAhvlrlN06cKQQUuM+asuLfaWsVicUU24SD331qpVw+Qhk+pbQhCwmE7WYS2iCkg xFzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=3fY520pK3MVFPuA8Ln4OHGZP00waF5d15Pwyeg+Ytn8=; b=dyHR5tjpvgNvSrAU1uPJJMH9flfoRLC4h/pIfLUMpSo5rxPv1fZ90or6oIaKOOdCXz p4RrOFAaxQEkrhyl8bQR+1IOic4Uzett+uEZT6Fg9VxmT50P5AJD1V3n5FXpd9sGuYoS WKXsMLAoc5A2VPFRxGNC8nDYULT51bIin10/BvrIdi5lIo7AAZTSPviVGtm1LjF282uf lo/3TwNMXfeayxwLkc+D9239SMwKg+1NSqR8H/Z+STCPC/UpdpiQO9MH44AaHl/NKiR3 eRYVtnSk1BjU7vKToNcAvi9RTP25XFOMao66ArTuauvYg/D/Hx9WY5aDuH0pHo0GJrcG YzPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="hUYQkC3/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t191-v6si15432744pgc.481.2018.08.13.07.47.49; Mon, 13 Aug 2018 07:48:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="hUYQkC3/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729369AbeHMQbH (ORCPT + 99 others); Mon, 13 Aug 2018 12:31:07 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:41737 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbeHMQbH (ORCPT ); Mon, 13 Aug 2018 12:31:07 -0400 Received: by mail-yw1-f66.google.com with SMTP id q129-v6so13563002ywg.8; Mon, 13 Aug 2018 06:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3fY520pK3MVFPuA8Ln4OHGZP00waF5d15Pwyeg+Ytn8=; b=hUYQkC3/S6+l5kvwBkMQDaPxUkwku2LiPeZqhpuv27PCvmRd/HvWPkoNCPx3mlaaRn 7kkcZ6y1BMtfKlLGxjbJhKkpMwMio50GAcDr1K6lVdYStKqRCeLBG37psUDU++4ukXaY aF0nvgCvh42hC5SQQlzl8p7SdSQdTflDV73lrNI1MnFK0pJHgHNI0ob3MPjkozhatKgG pMg6KmmuveUEn91JRzGLcyocX7JG8rGRf9PDNup5E+FedYFigwatgPook4jRvRNCiZff lPYSZSLEIOAiDgD1x2nunW59dJPmnnh9NO54bEnEO5aYaaBiXzVyu0Z4Qo0P3j81eaiN UzcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=3fY520pK3MVFPuA8Ln4OHGZP00waF5d15Pwyeg+Ytn8=; b=fVSwIBxfYAM0BadNssxKWtYieP9PwL8Ta2gstrBuKxFv0EGCQCsiZ4gZh/yGKqOc/9 G61JwNWAVHwhYnUT9x3YPhqRqktsViEZ6aVOkHu0VSXZU+L/gQp29GAseCK0cYJ/4nWC vfmYKdXXX0WId9kuK4dL4ldbsL34V+Kt6AFduYqR3Mo7DrzJIv1ayFykAE5zjr8HCXoi ouQafYh1t28Qo52PgOblCRk1VBe6NBckl0WBn+zH1verT4DjfyQl40srqTtPPjz3Ic5b tIUnWdOPwr1jx/08f0SYEWYWrXEuMNbDboKeacNb6xOP+oX9MByE+oufnZDE+974toi1 Jg3Q== X-Gm-Message-State: AOUpUlE1kxoyLWHDYINQMLkYu5I4E/ekjJ3pq+pS/uH+wvfg/RG8yKDd hNGtxVdRI3n9rMv8fjmC8NY= X-Received: by 2002:a0d:f443:: with SMTP id d64-v6mr8913189ywf.461.1534168125285; Mon, 13 Aug 2018 06:48:45 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::1:6555]) by smtp.gmail.com with ESMTPSA id b6-v6sm8662533ywb.78.2018.08.13.06.48.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Aug 2018 06:48:44 -0700 (PDT) Date: Mon, 13 Aug 2018 06:48:42 -0700 From: Tejun Heo To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Michal Hocko , Vladimir Davydov , Roman Gushchin , Johannes Weiner Subject: Re: [PATCH RFC 1/3] cgroup: list all subsystem states in debugfs files Message-ID: <20180813134842.GF3978217@devbig004.ftw2.facebook.com> References: <153414348591.737150.14229960913953276515.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153414348591.737150.14229960913953276515.stgit@buzz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Konstantin. On Mon, Aug 13, 2018 at 09:58:05AM +0300, Konstantin Khlebnikov wrote: > After removing cgroup subsystem state could leak or live in background > forever because it is pinned by some reference. For example memory cgroup > could be pinned by pages in cache or tmpfs. > > This patch adds common debugfs interface for listing basic state for each > controller. Controller could define callback for dumping own attributes. > > In file /sys/kernel/debug/cgroup/ each line shows state in > format: =... [-- =... ] Seems pretty useful to me. Roman, Johannes, what do you guys think? Thanks. -- tejun