Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3370289imm; Mon, 13 Aug 2018 10:27:30 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzekz3bX/WLyZxuQRbgslJEmsXC/ZbLRT7/MHTk1igg45rEYA1BaZcMl3jQRGrjV8fdKI84 X-Received: by 2002:a62:ac12:: with SMTP id v18-v6mr19730889pfe.126.1534181250661; Mon, 13 Aug 2018 10:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534181250; cv=none; d=google.com; s=arc-20160816; b=Gva9VGz84le975TOU2AnH11k7GuUXLn2CfqiNDPOuB4lj/xl8+hl5KVD+Mk1/oF3x9 G3FghJfSdoE364PwA2FdszCn/CkrYgqWuHzC5EDgaPgK351PwYphb+tJr6PqFMUHiU43 11E9dGmYN5xVy6y9chRGEm9vO2dbxQwx/YuaXK6xJa7f6RGTvT3PoxDPIAkJxFwr61qp tAJwq5LJA4LuHFUXbeAIIdZOu/266FaruHc4yL+REC48+gUuYD+QmhQV606q+1xY+qEZ 2DjwKER5Jj7b4cRGKRUlhjxm7sPSd/HjNRo17njC+QCBKa0Udf7Nuemff5B5I/G485ex 4riw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=DYYTAJU6Crln25grSZR2ST/rXoTw0Ti7adgbqgsKLWs=; b=Ff6Y0UtUazqGMxYwvX6RvOCpdkC0JeGytnz9fzkFuHQHtjzLA9fNUq1w+sb6imQ65/ +t7pYxVD/8yoeDl1soelZRFvRvT2mg2ksNdqCq0tocpFYgc71ojuGMv8suVGr0nLNSm+ JZ2DUPu1OJyXJPqiYbpta2enyLc4U0lDPaKwwZOew4fTOkEtaHTBy5JCdE/KkhtX+Ay3 yjlHgHaTbtogoe0oYemBSBgtXCXV040lct1CTzm2sfVTn6PYN9QcjPvK2YGO7iM9G/x7 5pDthtti86TC/tpcoz5DEw1h/zn2L2mpSd27qx+0o9YAPk6XtqEll3mWLNSs0OU+hJI9 HqaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q74-v6si21299182pfq.32.2018.08.13.10.27.14; Mon, 13 Aug 2018 10:27:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730016AbeHMShq (ORCPT + 99 others); Mon, 13 Aug 2018 14:37:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52918 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729944AbeHMShq (ORCPT ); Mon, 13 Aug 2018 14:37:46 -0400 Received: from localhost (c-24-20-22-31.hsd1.or.comcast.net [24.20.22.31]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 754FE1458045D; Mon, 13 Aug 2018 08:54:57 -0700 (PDT) Date: Mon, 13 Aug 2018 08:54:56 -0700 (PDT) Message-Id: <20180813.085456.1905254242911513146.davem@davemloft.net> To: salil.mehta@huawei.com Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linyunsheng@huawei.com Subject: Re: [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest From: David Miller In-Reply-To: <20180812094738.14852-2-salil.mehta@huawei.com> References: <20180812094738.14852-1-salil.mehta@huawei.com> <20180812094738.14852-2-salil.mehta@huawei.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 Aug 2018 08:54:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Salil Mehta Date: Sun, 12 Aug 2018 10:47:30 +0100 > -#define HNS3_SELF_TEST_TPYE_NUM 1 > +#define HNS3_SELF_TEST_TPYE_NUM 2 Is this supposed to be the number of self test "types"? If so, this CPP macro should be named "HNS3_SELF_TEST_TYPE_NUM". > + > + count ++; ^ Please remove that unnecessary space. > + } while (++i < HCLGE_SERDES_RETRY_NUM && ^^ Only need one space there, not two.