Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3453873imm; Mon, 13 Aug 2018 11:59:26 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzX58KVFIhIso0t6t2xtAIDTlkHnxk7CYYEoFOLGUahE5s4+vaToEVMlPanItQANJawn1Mt X-Received: by 2002:a65:5a8a:: with SMTP id c10-v6mr17584826pgt.389.1534186766798; Mon, 13 Aug 2018 11:59:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534186766; cv=none; d=google.com; s=arc-20160816; b=KGizRfU6BF+hYdNPA4Zf8E+e9j/tqsuBAh1QGd4Y/ygfl7q2daH192ewH4bwdPlgGT Z3MN211s+YdiHU+tbL82H3TKsklvnDUNI4eM/G8Qx81JL998xEI6FRrmeIp2djrfmLif INr9v6BLzABp/1ZEPj8HJFhZh+Ajuob/HN0YlwhvxpJUlqeoK5b2nsLGsvsoF0mfIzWN hxbJ8Fpy3W/V/2sSATpoD9fRgkZkG4zgN/p+dh85+8vzHBcT1Gq8af158TJFhVjbdWlP lY3vqJb5DTZjtEE5Pj/GAsV/fo4sxlosp6uEQcmnYBhxbxkyvwXGmUbnPZ18oZ14vzsC RBTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:arc-authentication-results; bh=zqpEiHvEG9gs8HavZL/WVFV/WZCK9w3sOWC3hIlF7tE=; b=KgOgUqPYZWTyK9ZBEI71wSlP9xJ2AtIYo4SBHTp7bXN3HlOaOvCatiSukjh5z/1s5X QDIt3rfszNzw5e6GzdgDx7R9ttqwMtjpk0kweWd52j816b+JnRy4xGmiUwVNe3gzpcvT kgrJOEKGhdakAw/pBjeABs+aso7MOiRR9h/NPs+/xcwBpz4/YK9F4kjmlwEcrJapNLA/ Fton4xk1GCCYH6wNyzVPogQ1IJE844DyjBdVjC63drC5KQZefpHWwhPW2BCOrj4vPByS K+cHR9cQaqh3V934Le8kzG8LM+yL7k/Pa600U79pECPLy00IcPyGKjovKmv6+4TwgAHM Ljzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p187-v6si20762872pfp.27.2018.08.13.11.59.10; Mon, 13 Aug 2018 11:59:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730141AbeHMVTU (ORCPT + 99 others); Mon, 13 Aug 2018 17:19:20 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:8627 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729748AbeHMVTU (ORCPT ); Mon, 13 Aug 2018 17:19:20 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Mon, 13 Aug 2018 11:35:38 -0700 Received: from HQMAIL101.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 Aug 2018 11:35:56 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 Aug 2018 11:35:56 -0700 Received: from [10.2.160.156] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 13 Aug 2018 18:35:55 +0000 Subject: Re: [PATCH] drivers/thermal/tegra: fix a doule free devce node From: Jon Hunter To: zhong jiang , , CC: , , , linux-tegra References: <1533822056-33930-1-git-send-email-zhongjiang@huawei.com> <312fcf2a-ab47-9aa4-3b1f-bca5f6a4d58c@nvidia.com> Message-ID: <88fb9427-9f3d-3ddb-c4cc-00b6e4de76ce@nvidia.com> Date: Mon, 13 Aug 2018 19:35:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <312fcf2a-ab47-9aa4-3b1f-bca5f6a4d58c@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding linux-tegra ... On 13/08/18 19:30, Jon Hunter wrote: > > On 09/08/18 14:40, zhong jiang wrote: >> Device node iterators will get the return node. Meawhile, It is >> also put the previous device node. An explicit put will cause >> a double put. >> >> Signed-off-by: zhong jiang >> --- >> drivers/thermal/tegra/soctherm.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >> index ed28110..3aa55c9 100644 >> --- a/drivers/thermal/tegra/soctherm.c >> +++ b/drivers/thermal/tegra/soctherm.c >> @@ -980,7 +980,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) >> tcd = thermal_of_cooling_device_register(np_stcc, >> (char *)name, ts, >> &throt_cooling_ops); >> - of_node_put(np_stcc); >> if (IS_ERR_OR_NULL(tcd)) { >> dev_err(dev, >> "throttle-cfg: %s: failed to register cooling device\n", >> > > Thanks! > > Acked-by: Jon Hunter Just need to fix the typos in the subject and commit log. Cheers Jon -- nvpublic