Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3473918imm; Mon, 13 Aug 2018 12:19:44 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwjHXhrI+IjU9P9rG7nDUAzrQ6gK/CmE1V/Se9jMoOeIbB5XQ423wOe2NzU5MbBVNEcctTC X-Received: by 2002:a62:4808:: with SMTP id v8-v6mr20290807pfa.89.1534187984164; Mon, 13 Aug 2018 12:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534187984; cv=none; d=google.com; s=arc-20160816; b=OM9cqYhjst9OE/JaqpmF9XpuC7hzOyTo5pf+KZlUtBZ/CW5lEH86X17wt/jwl6c1aC Gtsgboah24S1t0oN79v9lMvzesH5tLOx/AnoOEU/e80/bAmd3gvFa4Y30Z2vgrolSzI/ mp3o+UT3srW7IbDjN2pobAEfg1GpRVeLd/bpBkQgD8iF3NJOiR929AHG4ktNkrLvU6+W 2mnGT5ccTVA2XVKjAOFdhrYglDWT//fSZ0vhHj0jGYgcSOm6bqxMJZLa8QVEP+F7lQiN KeHaRSa4pi81KeOgR0hf0MfpQopc3ZstP/shaddoly+GDMSMHST+bPVCshURbuN66H+p 3JRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=DgFnHw0qcCzNp2Amu/dkXqiuq78oI5l8X6kE2GQ7tR8=; b=aduHSv96WiP0yMxPre1ReN50TfGPRUaJ/rA29cd4tcxW5L1+cE7vU+IjhzxQfr48oe +jaNFCTWDl3YtX5hzfQdqQ8SX/wOp5JqEOYn5vwZxlYeUVEkxDFwpKeozFmM66HOJ4KG iP8p5TJlTYYZ+kjQ2f0zR6P4uHenWL69jeYRPyDzFCO75tkmK3T8J0y2Xb5FPyklj+EX Q/21tovPisD/kVhf2ThVrKmejdAlPVV3kWsXwqjD6Ie1R24vQlx0V8rHW30iNRuRbN+m JbdbSq45K6KvgwJgi7+zQDoNfGTsfwmQ+BIr0bYXDyMb+gd+NwV8VO7nNdBaJ3y0ojvA pz8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m13-v6si19145185pgk.251.2018.08.13.12.19.29; Mon, 13 Aug 2018 12:19:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730862AbeHMWAi (ORCPT + 99 others); Mon, 13 Aug 2018 18:00:38 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729682AbeHMWAh (ORCPT ); Mon, 13 Aug 2018 18:00:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06F65818F03A; Mon, 13 Aug 2018 19:17:05 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-11.bss.redhat.com [10.20.1.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D95F2156712; Mon, 13 Aug 2018 19:17:04 +0000 (UTC) From: Lyude Paul To: nouveau@lists.freedesktop.org Cc: stable@vger.kernel.org, Lukas Wunner , Karol Herbst , Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 2/5] drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() Date: Mon, 13 Aug 2018 15:16:42 -0400 Message-Id: <20180813191648.27419-3-lyude@redhat.com> In-Reply-To: <20180813191648.27419-1-lyude@redhat.com> References: <20180813191648.27419-1-lyude@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 13 Aug 2018 19:17:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 13 Aug 2018 19:17:05 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lyude@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since actual hotplug notifications don't get disabled until nouveau_display_fini() is called, all this will do is cause any hotplugs that happen between this drm_kms_helper_poll_disable() call and the actual hotplug disablement to potentially be dropped if ACPI isn't around to help us. Signed-off-by: Lyude Paul Cc: stable@vger.kernel.org Cc: Lukas Wunner Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index c7ec86d6c3c9..5fdc1fbe2ee5 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -835,7 +835,6 @@ nouveau_pmops_runtime_suspend(struct device *dev) return -EBUSY; } - drm_kms_helper_poll_disable(drm_dev); nouveau_switcheroo_optimus_dsm(); ret = nouveau_do_suspend(drm_dev, true); pci_save_state(pdev); -- 2.17.1