Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Aug 2018 15:55:11 -0300
From:   Arnaldo Carvalho de Melo <acme@redhat.com>
To:     Kim Phillips <kim.phillips@arm.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Dongjiu Geng <gengdongjiu@huawei.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error
 variable
Message-ID: <20180813185511.GA2146@redhat.com>
References: <20180810174512.52900813e57cbccf18ce99a2@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180810174512.52900813e57cbccf18ce99a2@arm.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu:
> The auxtrace init variable 'err' was not being initialized, leading
> perf to abort early in an SPE record command when there was no explicit
> error, rather only based whatever memory contents were on the stack.
> Initialize it explicitly on getting an SPE successfully, the same way
> cs-etm does.
> 
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> ---
> Hi Arnaldo, please apply to perf/urgent / stable series if at all
> possible.  Thank you.

In such cases the best thing is to have a "Fixes: ..." so that this gets
automatically picked by the stabe trees, I'll try to find out what was
the patch that introduced this problem.

- Arnaldo