Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAK7LNAQ2THEDLB8so3zahGykH_BWaWAU7Tg_2yGEPKo+ApsxHg@mail.gmail.com>
References: <20180811094853.32167-1-stefan@agner.ch> <CAK7LNAQ2THEDLB8so3zahGykH_BWaWAU7Tg_2yGEPKo+ApsxHg@mail.gmail.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Mon, 13 Aug 2018 13:10:52 -0700
Message-ID: <CAGXu5jKHbx-L+n+CCExshtW1uQqkRX6MS5SoEH068DzoB+oKEg@mail.gmail.com>
Subject: Re: [PATCH] gcc-plugins: require GCC
To:     Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     Stefan Agner <stefan@agner.ch>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Josef Bacik <jbacik@fb.com>, Emese Revfy <re.emese@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 13, 2018 at 12:38 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2018-08-11 18:48 GMT+09:00 Stefan Agner <stefan@agner.ch>:
>> Unsurprisingly GCC plugins require GCC as a compiler. This avoids
>> GCC plugins being selectable when using clang.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>>  arch/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index 1aa59063f1fd..8c693a837ed7 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -422,7 +422,7 @@ config HAVE_GCC_PLUGINS
>>
>>  menuconfig GCC_PLUGINS
>>         bool "GCC plugins"
>> -       depends on HAVE_GCC_PLUGINS
>> +       depends on HAVE_GCC_PLUGINS && CC_IS_GCC
>>         depends on PLUGIN_HOSTCC != ""
>>         help
>>           GCC plugins are loadable modules that provide extra features to the
>> --
>> 2.18.0
>>
>
> I guess the more correct way is to fix
> scripts/gcc-plugin.sh
>
> This shell script should exit 0
> only when GCC plugin is supported.

I'm of two minds: we already have the gcc test in Kconfig so we might
want to avoid redundant checks, but maybe the script should be a
"complete" test. I guess the latter. I will send a patch.

-Kees

-- 
Kees Cook
Pixel Security