Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <a5899fe3c616db608d45303e9ac4563df6546333.camel@perches.com>
Subject: Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if
 structs are too large
From:   Joe Perches <joe@perches.com>
To:     Roman Kiryanov <rkir@google.com>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        Todd Kjos <tkjos@google.com>
Date:   Mon, 13 Aug 2018 21:41:06 -0700
In-Reply-To: <CAOGAQerZ9D2gs+dmv5VKH_0GZQvnGY=juQLQa3qQ-cEm4qn1tQ@mail.gmail.com>
References: <20180813233839.190855-1-rkir@google.com>
         <20180813233839.190855-6-rkir@google.com>
         <a7a81091a1856bcd2ec7dd6a17270dd999058475.camel@perches.com>
         <CAOGAQerZ9D2gs+dmv5VKH_0GZQvnGY=juQLQa3qQ-cEm4qn1tQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-08-13 at 20:47 -0700, Roman Kiryanov wrote:
> Hi,
> 
> thank you for reviewing my patches. I decided to put BUILD_BUG_ON
> close to places where it is important that these structs fit into a
> memory page to give some context.

And you make the reader figure out what type dev->buffers is
unnecessarily when sizeof(struct goldfish_pipe_dev_buffers)
is pretty obvious.

> Regards,
> Roman.

cheers, Joe