Received: by 2002:a4a:311b:0:0:0:0:0 with SMTP id k27-v6csp4091878ooa; Tue, 14 Aug 2018 00:35:17 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyFIxqjTZGcLKMkfGqVeNKyxAyAfzeaMQf7GW7oou5jKxbw5dhXjUf5KmX69eyVqzhdGjcA X-Received: by 2002:a17:902:760b:: with SMTP id k11-v6mr19525617pll.91.1534232117301; Tue, 14 Aug 2018 00:35:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534232117; cv=none; d=google.com; s=arc-20160816; b=uVOFRg3insjcw99flrCkUuMV9QAgWyOM0BfBUMOOHm37CjczsPSPaG/WSKi1uOje7B 4deE9OS5DAwtQoh9VyCxkeEBxfYnGNKI8Wp6RP3CeegKlyDPtDnMRbgtLfUpQLbW0gW+ rVOZRQ9dD2xFnepoDHbEu7pWtcaNNmmB5MynZxFUwqDZk3P4zkcfzp/cli5c031efbp6 g9avTc17oyGMXSLhA5eJ5oKbX8yrTf/r2vwY0wHSlQWBPZM3m6I00TWBfjxAy4JsvX7R 6zvLNoXlKcEp/xY5qUVY6yREk8PzGm56eoVrx3pxbRYP2/I8i7sZ8OrsGPKSoLAADIXp Tfrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=0dJS9n8R1lZdbve5LJjZ0sCF1p2R9m1d9Ue6pP+DsN4=; b=nkO8k/CgpezW05OAanXtMWk8d88OONVDuCUbsXDTPock5C2vGHg7Wa7ElqsW7MOCe3 J0KAD2doEzzvl+9nv/o8FGs5YQQixiuXNMF+eEjMHnFmR43ESHngiO+fugmX42r9rH/M 4kcUfCcUJ3Jv0kFbICx/9TIu1riNWFc7xTiIwJk9golar+MZsBKilmrjpNOIEMMkTPoH B+UhuULeuexdNuCRAw4j6yHqHIz/06Gfmkmb4/r6Z0At5jDuYGGmzlqUlsxshKlcDpsC bjnxqdUf87x10GOiIc7+EviTGgPOnutvZCnHG1Ekgw4rGL8S6JG+gF7ddQvaAylTUaTK G0Kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8-v6si18659359pgl.101.2018.08.14.00.35.02; Tue, 14 Aug 2018 00:35:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732009AbeHNKTI (ORCPT + 99 others); Tue, 14 Aug 2018 06:19:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:54244 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731213AbeHNKTI (ORCPT ); Tue, 14 Aug 2018 06:19:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 18B8EAF4F; Tue, 14 Aug 2018 07:33:10 +0000 (UTC) From: Hannes Reinecke To: Jens Axboe Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Bart van Assche , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Linux Kernel Mailinglist , Hannes Reinecke Subject: [PATCHv2 0/5] genhd: register default groups with device_add_disk() Date: Tue, 14 Aug 2018 09:33:00 +0200 Message-Id: <20180814073305.87255-1-hare@suse.de> X-Mailer: git-send-email 2.12.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org device_add_disk() doesn't allow to register with default sysfs groups, which introduces a race with udev as these groups have to be created after the uevent has been sent. This patchset updates device_add_disk() to accept a 'groups' argument to avoid this race and updates the obvious drivers to use it. There are some more drivers which might benefit from this (eg loop or md), but the interface is not straightforward so I haven't attempted it. Patches are relative to Christophs nvme-4.19 branch. As usual, comments and reviews are welcome. Changes to v1: - Drop first patch - Convert lightnvm sysfs attributes as suggested by Bart Hannes Reinecke (5): block: genhd: add 'groups' argument to device_add_disk nvme: register ns_id attributes as default sysfs groups aoe: use device_add_disk_with_groups() zram: register default groups with device_add_disk() virtio-blk: modernize sysfs attribute creation arch/um/drivers/ubd_kern.c | 2 +- block/genhd.c | 19 ++++++++--- drivers/block/aoe/aoe.h | 1 - drivers/block/aoe/aoeblk.c | 21 ++++-------- drivers/block/aoe/aoedev.c | 1 - drivers/block/floppy.c | 2 +- drivers/block/mtip32xx/mtip32xx.c | 2 +- drivers/block/ps3disk.c | 2 +- drivers/block/ps3vram.c | 2 +- drivers/block/rsxx/dev.c | 2 +- drivers/block/skd_main.c | 2 +- drivers/block/sunvdc.c | 2 +- drivers/block/virtio_blk.c | 68 +++++++++++++++++++++---------------- drivers/block/xen-blkfront.c | 2 +- drivers/block/zram/zram_drv.c | 28 ++++----------- drivers/ide/ide-cd.c | 2 +- drivers/ide/ide-gd.c | 2 +- drivers/memstick/core/ms_block.c | 2 +- drivers/memstick/core/mspro_block.c | 2 +- drivers/mmc/core/block.c | 2 +- drivers/mtd/mtd_blkdevs.c | 2 +- drivers/nvdimm/blk.c | 2 +- drivers/nvdimm/btt.c | 2 +- drivers/nvdimm/pmem.c | 2 +- drivers/nvme/host/core.c | 21 +++++------- drivers/nvme/host/lightnvm.c | 27 +++------------ drivers/nvme/host/multipath.c | 15 +++----- drivers/nvme/host/nvme.h | 11 ++---- drivers/s390/block/dasd_genhd.c | 2 +- drivers/s390/block/dcssblk.c | 2 +- drivers/s390/block/scm_blk.c | 2 +- drivers/scsi/sd.c | 2 +- drivers/scsi/sr.c | 2 +- include/linux/genhd.h | 5 +-- 34 files changed, 113 insertions(+), 150 deletions(-) -- 2.12.3